Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore handling for Timed.percentiles() in TimedAspect #5475

Merged

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Sep 11, 2024

This PR restores handling for the Timed.percentiles() in the TimedAspect as it seems to have been removed accidentally in 1061499#diff-b55b9ffafa609bfca1d0c14d92b061277165d6da05444010f8c9c161380b2d29L257.

See gh-5145

@jonatan-ivanov jonatan-ivanov added the bug A general bug label Sep 11, 2024
@jonatan-ivanov jonatan-ivanov added this to the 1.14.0-RC1 milestone Sep 11, 2024
@jonatan-ivanov jonatan-ivanov merged commit 9991df4 into micrometer-metrics:main Sep 11, 2024
6 checks passed
@jonatan-ivanov
Copy link
Member

Thank you!

@izeye izeye deleted the gh-5145-fix-percentiles branch September 11, 2024 21:03
@izeye
Copy link
Contributor Author

izeye commented Sep 11, 2024

@jonatan-ivanov Thanks!

By the way, the "regression" label seems to be better for this.

@jonatan-ivanov jonatan-ivanov added regression A regression from a previous release and removed bug A general bug labels Sep 11, 2024
@jonatan-ivanov
Copy link
Member

You are right, thank you!

@shakuzen
Copy link
Member

Good catch. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression A regression from a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants