Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow propagating spans via ThreadLocalAccessors #206

Closed
marcingrzejszczak opened this issue Mar 17, 2023 · 0 comments
Closed

Allow propagating spans via ThreadLocalAccessors #206

marcingrzejszczak opened this issue Mar 17, 2023 · 0 comments
Assignees
@marcingrzejszczak
Labels
enhancement New feature or request
Milestone
1.0.4

Comments

@marcingrzejszczak
Copy link
Contributor

currently we only propagate Observation via ObservationThreadLocalAccessors. Users might want to just use the Tracing API and should be allowed to propagate tracing info between e.g. threads.

related issue spring-projects/spring-boot#34622
@marcingrzejszczak marcingrzejszczak added the enhancement New feature or request label Mar 17, 2023
@marcingrzejszczak marcingrzejszczak mentioned this issue Mar 17, 2023
Closed
@marcingrzejszczak marcingrzejszczak self-assigned this Mar 21, 2023
marcingrzejszczak added a commit that referenced this issue Mar 21, 2023
@marcingrzejszczak
Adds support for ObservationAwareSpanThreadLocalAccessor
a789038 
without this change you can't propagate just micrometer tracing spans with context propagation

with this change we're introducing an ObservationAwareSpanThreadLocalAccessor that is a ThreadLocalAccessor that knows about the existence of the ObservationThreadLocalAccessor. If OTLA started a span, the OASTLA will back off. If there was no observation and no span there, OASTLA will return an instance of a span. Since ordering matters, OAWSTLA will not be registered in the SPI mechanism, the user will need to set the ContextPropagation registry manually to ensure that OASTLA is registered AFTER OTLA.

fixes gh-206
@marcingrzejszczak marcingrzejszczak mentioned this issue Mar 21, 2023
Merged
@marcingrzejszczak marcingrzejszczak added this to the 1.0.4 milestone Mar 22, 2023
@marcingrzejszczak marcingrzejszczak mentioned this issue Mar 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcingrzejszczak marcingrzejszczak

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.4
Development

No branches or pull requests
1 participant
@marcingrzejszczak