Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency org.eclipse.jetty:jetty-server to v12 #544

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 7, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.eclipse.jetty:jetty-server (source) 11.0.20 -> 12.0.7 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "after 10pm" in timezone Europe/Prague, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the type: dependency-upgrade Upgrade a dependency label Aug 7, 2023
@renovate renovate bot force-pushed the renovate/major-jetty.server branch from 55ff53f to 6c7c874 Compare August 15, 2023 16:04
@renovate renovate bot force-pushed the renovate/major-jetty.server branch 2 times, most recently from 03f36a6 to 56ac903 Compare August 31, 2023 00:15
@renovate renovate bot force-pushed the renovate/major-jetty.server branch from 56ac903 to dda55ee Compare October 10, 2023 06:29
@renovate renovate bot force-pushed the renovate/major-jetty.server branch 2 times, most recently from b92156f to 00b15dd Compare October 31, 2023 11:36
@renovate renovate bot force-pushed the renovate/major-jetty.server branch 3 times, most recently from fd5720d to de02810 Compare December 8, 2023 07:26
@renovate renovate bot force-pushed the renovate/major-jetty.server branch from de02810 to 65f46f3 Compare December 20, 2023 01:55
@renovate renovate bot force-pushed the renovate/major-jetty.server branch from 65f46f3 to 18a3c38 Compare January 22, 2024 10:13
@renovate renovate bot force-pushed the renovate/major-jetty.server branch from 18a3c38 to 21be61a Compare January 31, 2024 15:25
@sdelamo
Copy link
Contributor

sdelamo commented Feb 28, 2024

@wetted change the build so that it uses the version defined in servlet for jetty.

@renovate renovate bot force-pushed the renovate/major-jetty.server branch from 21be61a to 20425ba Compare February 29, 2024 19:14
@wetted
Copy link
Contributor

wetted commented Feb 29, 2024

@wetted change the build so that it uses the version defined in servlet for jetty.

@sdelamo micronaut-servlet doesn't expose jetty as a managed dependency. This PR is for a major update of jetty-server, and the build is broken. In the meantime I merged the patch update PR on #636.

Let me know how you want me to proceed further.

@wetted wetted requested a review from sdelamo February 29, 2024 19:24
@sdelamo
Copy link
Contributor

sdelamo commented Mar 4, 2024

#636

create a PR in servlet to expose the jetty version

@wetted
Copy link
Contributor

wetted commented Mar 4, 2024

create a PR in servlet to expose the jetty version

see micronaut-projects/micronaut-servlet#651

@renovate renovate bot force-pushed the renovate/major-jetty.server branch from 20425ba to 8b78aeb Compare March 6, 2024 17:46
@sdelamo
Copy link
Contributor

sdelamo commented Mar 7, 2024

@wetted use Servlet 4.6.0 to get rid of the jetty version

@wetted wetted closed this Mar 7, 2024
@wetted wetted deleted the renovate/major-jetty.server branch March 7, 2024 17:10
Copy link
Contributor Author

renovate bot commented Mar 7, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 12.x releases. But if you manually upgrade to 12.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@wetted wetted restored the renovate/major-jetty.server branch March 7, 2024 17:10
@wetted wetted reopened this Mar 7, 2024
Copy link
Contributor Author

renovate bot commented Mar 7, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wetted
Copy link
Contributor

wetted commented Mar 7, 2024

ping @sdelamo this is good to go now

@sdelamo sdelamo merged commit ce8c24e into master Mar 8, 2024
11 checks passed
@sdelamo sdelamo deleted the renovate/major-jetty.server branch March 8, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants