Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not inject Netty's EventLoopGroup as a primary ExecutorService #4004

Closed
dstepanov opened this issue Sep 2, 2020 · 3 comments · Fixed by #5560
Closed

Do not inject Netty's EventLoopGroup as a primary ExecutorService #4004

dstepanov opened this issue Sep 2, 2020 · 3 comments · Fixed by #5560
Assignees
@jameskleeh
Labels
priority: high High priority
Milestone
3.0.0

Comments

@dstepanov
Copy link
Contributor

It's caused by @Primary annotation added for default EventLoopGroup in DefaultEventLoopGroupRegistry.

Would it be possible to allow specifying something like @Primary(of = EventLoopGroup.class)? That would restrict injecting ExecutorService as a primary implementation.
@graemerocher graemerocher added the status: under consideration The issue is being considered, but has not been accepted yet label Sep 2, 2020
@jameskleeh
Copy link
Contributor

@dstepanov Can you describe what issue is being caused by the current behavior?

@dstepanov
Copy link
Contributor Author

@jameskleeh #3868 I wouldn't expect Netty executor to be injected as a default one it probably can cause some performance problems if it's used to execute long-running tasks.

@jameskleeh jameskleeh added this to the 3.0.0 milestone Mar 11, 2021
@jameskleeh
Copy link
Contributor

We will remove the primary qualifier

@graemerocher graemerocher added priority: high High priority and removed status: under consideration The issue is being considered, but has not been accepted yet labels Mar 11, 2021
@jameskleeh jameskleeh self-assigned this Jun 9, 2021
jameskleeh added a commit that referenced this issue Jun 9, 2021
@jameskleeh
Only expose event loop group as EventLoopGroup and not ExecutorService.
08bb35b 
Closes #4004
@jameskleeh jameskleeh linked a pull request Jun 9, 2021 that will close this issue
Only expose EventLoopGroup as an injection type for the Netty default loop #5560
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameskleeh jameskleeh

Labels
priority: high High priority
Projects
None yet
Milestone
3.0.0
3 participants
@graemerocher @dstepanov @jameskleeh