Allow client config of WebSocket per message deflate #10357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a configuration property to HttpClientConfiguration that allows the enabling or disabling of per message deflate. Defaults to true in order to preserve the existing behavior. Resolves #7711
|
@jeremyg484 |
I'll check it out, thanks for the heads up. |
timyates
suggested changes
Jan 12, 2024
...nt/src/test/groovy/io/micronaut/http/client/config/DefaultHttpClientConfigurationSpec.groovy
Outdated
Show resolved
Hide resolved
timyates
approved these changes
Jan 12, 2024
sdelamo
requested changes
Jan 22, 2024
|
sdelamo
approved these changes
Jan 23, 2024
http-client-core/src/main/java/io/micronaut/http/client/HttpClientConfiguration.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration property to HttpClientConfiguration that allows the enabling or disabling of per message deflate for WebSocket clients. Defaults to true in order to preserve the existing behavior.
This potentially resolves #7711
This PR is from a new branch based on 4.3.x and replaces #7809
Other related WebSocket configuration bits potentially worth supporting are captured in #9162