Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for programmatically adding bean configurations #11527

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

graemerocher
Copy link
Contributor

@graemerocher graemerocher commented Jan 22, 2025

Allows adding bean configurations at runtime that allow, for example, disabling certain beans within a package. Later it may make sense to allow @MicronautTest to use this disable certain beans as necessary.

@graemerocher graemerocher added the type: enhancement New feature or request label Jan 22, 2025
@dstepanov
Copy link
Contributor

Personally, I don't like this. People will end up disabling internal packages and then be upset if we modify something internally.

@graemerocher
Copy link
Contributor Author

I tried to exclude the critical packages and make the API difficult enough to use that it requires a bit of thought, but I understand the concern.

@dstepanov
Copy link
Contributor

We can add a check that will throw if one of the packages is io.micronaut

@graemerocher
Copy link
Contributor Author

there is a check already but it is limited to io.micronaut.context and io.micronaut.inject, you suggesting we not allow disabling of any Micronaut module?

@dstepanov
Copy link
Contributor

I would not allow to disable Micronaut packages

@graemerocher
Copy link
Contributor Author

ok will go with that

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
65.5% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@graemerocher graemerocher merged commit be6262e into 4.8.x Jan 30, 2025
21 of 22 checks passed
@graemerocher graemerocher deleted the bean-configurations branch January 30, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants