Add eq/hc for HttpVersionSelection

[yawkat]

Fixes #9994

[graemerocher]

please add a test

[yawkat]

hmm not sure how to test the original bug since it's a perf issue. but i guess i can unit the class.

[jpbempel]

I think there is still an issue in io.micronaut.http.client.netty.DefaultNettyHttpClientRegistry.ClientKey::equals code related to httpVersion

            return httpVersion == clientKey.httpVersion &&

should use equals because could be different instances

[graemerocher]

Good catch @yawkat there is still an issue

[altro3]

@yawkat you forgot this:

Moreover the ClientKey::equals use reference equality (==) for the httpVersion field which will be always false.

[yawkat]

thanks @jpbempel

[yawkat]

that one is even less testable unfortunately :(

[jpbempel]

that one is even less testable unfortunately :(

My suggestion would be to test the call io.micronaut.http.client.netty.DefaultNettyHttpClientRegistry#getClient(io.micronaut.core.annotation.AnnotationMetadata) twice and make sure the 2 DefaultHttpClient instances are the same.
This will call getClientKey generating a ClientKey instance with the HttpVersionSelection instance generated by forClientAnnotation::forClientAnnotation

[yawkat]

good idea!

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

60.7% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint