-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eq/hc for HttpVersionSelection #9999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test
hmm not sure how to test the original bug since it's a perf issue. but i guess i can unit the class. |
I think there is still an issue in
should use equals because could be different instances |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @yawkat there is still an issue
@yawkat you forgot this:
|
thanks @jpbempel |
that one is even less testable unfortunately :( |
My suggestion would be to test the call |
good idea! |
SonarCloud Quality Gate failed. 0 Bugs 60.7% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Fixes #9994