Stop trying to guess a port for Jetty in http-tests #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes how we generate a port for Jetty in the http-tests. Previously we tried to guess one then tried to start jetty on it in a retry loop. After this change, we just let Jetty pick a port by assigning it 0. This wasn't an issue in this module, but it has proved to be a source of flakiness in Azure, so I'm doing this for consistency
|
SonarCloud Quality Gate failed.
|
timyates
added a commit
to micronaut-projects/micronaut-aws
that referenced
this pull request
Dec 7, 2023
This gets rid of a load of code, and brings it in line with Azure and GCP See micronaut-projects/micronaut-gcp#1008 And micronaut-projects/micronaut-azure#603
sdelamo
approved these changes
Dec 7, 2023
sdelamo
pushed a commit
to micronaut-projects/micronaut-aws
that referenced
this pull request
Dec 7, 2023
This gets rid of a load of code, and brings it in line with Azure and GCP See micronaut-projects/micronaut-gcp#1008 And micronaut-projects/micronaut-azure#603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we generate a port for Jetty in the http-tests. Previously we tried to guess one then tried to start jetty on it in a retry loop. After this change, we just let Jetty pick a port by assigning it 0.
This wasn't an issue in this module, but it has proved to be a source of flakiness in Azure, so I'm doing this for consistency