Remove AuthenticationLoggingInterceptor

[jeremyg484]

Remove the AuthenticationLoggingInterceptor that was being applied to GoogleCredentials via an AOP proxy.

An alternate solution has been found to be able to detect and log the authentication failures (a separate PR forthcoming).

This will fix the issues with certain methods of GoogleCredentials being unable to be used as expected when proxied due to them being final.

This fix can be applied in a patch release, clearing the way for the alternate authentication support to be part of the next minor release.

This closes #997.

[timyates]

Should we have a test that shows "Calling googleCredentials.refreshIfExpired() followed by googleCredentials.getAccessToken().getTokenValue() results in a null pointer exception." (from the issue) is now working?

(just so we don't break it again in the future?)

[jeremyg484]

Should we have a test that shows "Calling googleCredentials.refreshIfExpired() followed by googleCredentials.getAccessToken().getTokenValue() results in a null pointer exception." (from the issue) is now working?

(just so we don't break it again in the future?)

Yes, I think that's a good idea, I'll attempt it. I believe I'll have to add a new mock endpoint to return a "valid" token to get that to work correctly.

[timyates]

Nice test! I checked it against master, and it fails as expected 🎉

Added a cleanup: block to the tests to close the application context where applicable 👍

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud