Micronaut 4.0.1 buildNativeLambda task breaks under Windows with StringIndexOutOfBoundsException
#805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`\E` was being incorrectly interpreted as a path separator on Windows
|
Kudos, SonarCloud Quality Gate passed! |
sdelamo
approved these changes
Aug 21, 2023
|
Fixed in #808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in #654 that affects only Windows.
The exclude-config arguments were being monkey-patched incorrectly: the last part of the regular expression
\Q ... \Ewas being interpreted as a path separator on Windows. This PR makeslastIndexOfignore that part.No additional tests are needed, because
LambdaNativeImageSpecwas already failing on Windows due to this issue. I removed@IgnoreIf({ os.windows })and it works fine after the bugfix.