Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: version to 4.0.0 Micronaut 4.0.0-SNAPSHOT githubCoreBranch=4.0.x remove deprecations #570

Merged
merged 6 commits into from
Sep 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,8 @@ plugins {
id "io.micronaut.build.internal.dependency-updates"
id "io.micronaut.build.internal.quality-reporting"
}

repositories {
mavenCentral()
maven { url "https://s01.oss.sonatype.org/content/repositories/snapshots/" }
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
repositories {
mavenCentral()
maven { url "https://s01.oss.sonatype.org/content/repositories/snapshots/" }
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
plugins {
id "io.micronaut.build.internal.grpc-base"
id "io.micronaut.build.internal.module"
}

repositories {
mavenCentral()
maven { url "https://s01.oss.sonatype.org/content/repositories/snapshots/" }
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
plugins {
id "io.micronaut.build.internal.grpc-base"
}
6 changes: 3 additions & 3 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
projectVersion=3.4.0-SNAPSHOT
projectVersion=4.0.0-SNAPSHOT
projectGroup=io.micronaut.grpc
micronautDocsVersion=2.0.0
micronautVersion=3.5.4
micronautVersion=4.0.0-SNAPSHOT
micronautTestVersion=3.4.0

micronautGradlePluginVersion=3.5.1
Expand All @@ -17,7 +17,7 @@ githubSlug=micronaut-projects/micronaut-grpc
developers=Graeme Rocher

githubBranch=master
githubCoreBranch=3.5.x
githubCoreBranch=4.0.x
bomProperty=micronautGrpcVersion
bomProperties=protobufJavaVersion,grpcVersion
# For sonarqube
Expand Down
20 changes: 20 additions & 0 deletions grpc-server-runtime/config/accepted-api-changes.json
Original file line number Diff line number Diff line change
Expand Up @@ -323,5 +323,25 @@
"type": "io.micronaut.grpc.server.tracing.GrpcServerTracingInterceptorFactory",
"member": "Constructor io.micronaut.grpc.server.tracing.GrpcServerTracingInterceptorFactory()",
"reason": "Not really a breaking change, just moving to the new module, where the server module has dependency on"
},
{
"type": "io.micronaut.grpc.server.GrpcServerBuilder",
"member": "Class io.micronaut.grpc.server.GrpcServerBuilder",
"reason": "removed deprecated constructor for Micronaut 4.0.x"
},
{
"type": "io.micronaut.grpc.server.GrpcServerBuilder",
"member": "Constructor io.micronaut.grpc.server.GrpcServerBuilder()",
"reason": "removed deprecated constructor for Micronaut 4.0.x"
},
{
"type": "io.micronaut.grpc.server.GrpcServerConfiguration",
"member": "Class io.micronaut.grpc.server.GrpcServerConfiguration",
"reason": "removed deprecated field for Micronaut 4.0.x"
},
{
"type": "io.micronaut.grpc.server.GrpcServerConfiguration",
"member": "Field HEALTH_ENABLED",
"reason": "removed deprecated field for Micronaut 4.0.x"
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,6 @@ public class GrpcServerBuilder {
@Nullable
private final HealthStatusManagerContainer healthStatusManagerContainer;

/**
* Constructs the {@link ServerBuilder} instance.
*
* @deprecated Use {@link #GrpcServerBuilder(HealthStatusManagerContainer)} instead.
*/
@Deprecated
public GrpcServerBuilder() {
this(null);
}

/**
* Constructs the {@link ServerBuilder} instance.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ public class GrpcServerConfiguration {
public static final String PORT = PREFIX + ".port";
public static final String HOST = PREFIX + ".host";
public static final String ENABLED = PREFIX + ".enabled";
@Deprecated
public static final String HEALTH_ENABLED = PREFIX + ".health.enabled";
public static final int DEFAULT_PORT = 50051;
public static final Duration DEFAULT_AWAIT_TERMINATION = Duration.ofSeconds(30);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,25 +42,6 @@ class GrpcServerInstance implements EmbeddedServerInstance {
private final ConvertibleValues<String> metadata;
private final EmbeddedServer embeddedServer;

/**
* Constructor.
*
* @param embeddedServer The embedded server
* @param id The ID
* @param uri The URI
* @param metadata The metadata
* @param metadataContributors The metadata contributors
*/
@Deprecated
GrpcServerInstance(
EmbeddedServer embeddedServer,
String id,
URI uri,
@Nullable Map<String, String> metadata,
@Nullable List<ServiceInstanceMetadataContributor> metadataContributors) {
this(embeddedServer, id, uri, metadata, metadataContributors, null);
}

/**
* Default constructor.
*
Expand Down
5 changes: 1 addition & 4 deletions test-suite-groovy/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@ plugins {
id 'groovy'
id 'com.google.protobuf'
id "io.micronaut.minimal.application" version "3.5.1"
}

repositories {
mavenCentral()
id "io.micronaut.build.internal.grpc-tests"
}

mainClassName = "helloworld.Application"
Expand Down
5 changes: 1 addition & 4 deletions test-suite-java/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ plugins {
id 'com.google.protobuf'
// end::plugin[]
id 'io.micronaut.application'
}

repositories {
mavenCentral()
id "io.micronaut.build.internal.grpc-tests"
}

mainClassName = "helloworld.Application"
Expand Down
5 changes: 1 addition & 4 deletions test-suite-kotlin/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ plugins {
id "org.jetbrains.kotlin.plugin.allopen" version "$kotlinVersion"
id "io.micronaut.application"
id "com.google.protobuf"
id "io.micronaut.build.internal.grpc-tests"
}

// tag::variables[]
Expand All @@ -12,10 +13,6 @@ ext {
}
// end::variables[]

repositories {
mavenCentral()
}

java {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
Expand Down