-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get more versions from version catalogs. #880
Conversation
@sdelamo review this PR, pls |
@@ -0,0 +1,12 @@ | |||
plugins { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you renaming to build-logic
? We should be consistent in every module and we use buildSrc
everywhere. Please, revert it to buildSrc
. Let's try to do small PRs without mixing several things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that now you use build-logic everywhere, because that’s what I see now in micronaut-openapi. I thought that everything needed to be brought to one form. I don’t know why in micronaut-openapi this folder was renamed to build-logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use buildSrc
in this Pr. Thanks.
Corrections in gradle scripts Update libs
@sdelamo Hm... I remembered what the problem was specifically in this module until I changed the name of buildSrc to build-logic. If I revert rename module buildSrc to build-logic now I have this error:
Now in buildSrc 2 gradle plugins for Kotlin are added in the implementation block. Our task is to get rid of duplication of versions of these plugins and take them from the core version catalog. As you can see, I managed to do this. If I leave a directory named buildSrc then I get the error I described above. But the problem is not only this, but the fact that I CANNOT add plugins from the plugins catalog to the implementation block. I think this has something to do with the fact that buildSrc is the gradle system directory, which it handles slightly differently than if you do it in a plugin like build-logic Well, you need to decide what is more important: duplication of versions or the name of the directory. Or is there some more correct solution so that you don’t have to rename directories and remove duplication of versions. PS Add @melix to this project pls, can't tag him |
But maybe now it is problem in build plugin:
|
Corrections in gradle scripts
Update libs