Skip to content

Commit

Permalink
fix: add @primary annotation for DefaultConstraintValidatorFactory (#370
Browse files Browse the repository at this point in the history
)

* fix(deps): update dependency io.micronaut.validation:micronaut-validation-bom to v4.4.0

* fix: add @primary annotation for DefaultConstraintValidatorFactory

A `ConstraintValidationFactory` aws added to Micronaut Validation in [PR 288](micronaut-projects/micronaut-validation#288). This PR sets the Hibernate Validator as the primary `ConstraintValidatorFactory` in case there are many in the classpath and avoids:

```
Caused by: io.micronaut.context.exceptions.NonUniqueBeanException: Multiple possible bean candidates found: [DefaultInternalConstraintValidatorFactory, DefaultConstraintValidatorFactory]
```

see: micronaut-projects/micronaut-sql#1266

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
  • Loading branch information
sdelamo and renovate[bot] authored Feb 19, 2024
1 parent cac616f commit cc20d91
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ managed-hibernate-validator = '8.0.1.Final'

micronaut-serde = "2.8.1"
micronaut-test = "4.0.0"
micronaut-validation = "4.2.0"
micronaut-validation = "4.4.0"

groovy = "4.0.13"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package io.micronaut.configuration.hibernate.validator;

import io.micronaut.context.BeanContext;
import io.micronaut.context.annotation.Primary;
import io.micronaut.context.exceptions.NoSuchBeanException;
import io.micronaut.core.reflect.InstantiationUtils;
import io.micronaut.inject.DisposableBeanDefinition;
Expand All @@ -31,6 +32,7 @@
* @author James Kleeh
* @since 1.1.0
*/
@Primary
@Singleton
public class DefaultConstraintValidatorFactory implements ConstraintValidatorFactory {

Expand Down

0 comments on commit cc20d91

Please sign in to comment.