-
Notifications
You must be signed in to change notification settings - Fork 106
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Retrieve kafka configuration with raw string convention. Fixes micron…
- Loading branch information
1 parent
319c7b1
commit 7a688f5
Showing
1 changed file
with
2 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a688f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change causes config via environment variables to be ignored. For example, set the bootstrap servers via application.yml and then attempt to override those via environment variable.
environment.getProperties(PREFIX) correctly returns the value set via the KAFKA_BOOTSTRAP_SERVERS environment variable.
environment.getProperties(PREFIX, StringConvention.RAW) returns the value of kafka.bootstrap.servers from application.yml.
7a688f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandon-johnson-globality can you report an issue?
7a688f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@graemerocher #179