Update BookSenderTest.java #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFAULT_BOOTSTRAP_SERVERS is defined as:
public static final String DEFAULT_BOOTSTRAP_SERVERS = "localhost:" + DEFAULT_KAFKA_PORT;
we want to set the kafka.bootstrap.servers or simply bootstrap.servers as seems to be used in KafkaDefaultConfiguration
The code as it stands sets the property "localhost:9021" to the value of "localhost:<random port>" which then fails to connect.
|
|
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFAULT_BOOTSTRAP_SERVERS is defined as:
public static final String DEFAULT_BOOTSTRAP_SERVERS = "localhost:" + DEFAULT_KAFKA_PORT;
we want to set the kafka.bootstrap.servers or simply bootstrap.servers as seems to be used in KafkaDefaultConfiguration
The code as it stands sets the property
localhost:9021to the value oflocalhost:<random port>which then fails to connect.