Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka transactions #447

Merged
merged 5 commits into from
Dec 3, 2021
Merged

Kafka transactions #447

merged 5 commits into from
Dec 3, 2021

Conversation

dstepanov
Copy link
Contributor

@dstepanov dstepanov commented Dec 1, 2021 •
edited
Loading

Fixes #104

graemerocher
graemerocher requested changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@graemerocher graemerocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just a few of changes

kafka/src/main/java/io/micronaut/configuration/kafka/KafkaProducerFactory.java Show resolved Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/Message.java Outdated Show resolved Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/TransactionalProducerRegistry.java Outdated Show resolved Hide resolved
@dstepanov dstepanov merged commit ddbd656 into master Dec 3, 2021
@dstepanov dstepanov deleted the tx branch December 3, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Transactions
2 participants
@dstepanov @graemerocher