Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepend tag names in kafka metric if using prometheus reporter #586

Closed

Conversation

yjiao-5028
Copy link

@yjiao-5028 yjiao-5028 commented Aug 16, 2022

@yjiao-5028 yjiao-5028 marked this pull request as ready for review August 16, 2022 01:06
@graemerocher graemerocher added this to the 4.5.0 milestone Nov 15, 2022
@graemerocher
Copy link
Contributor

so this PR has problems in that it adds coupling to the Prometheus registry implementation (see the errors in the tests). Using an instanceof check is unlikely to work as well if you have multiple meter registries (in which case the wrapped registry is a CompositeMeterRegistry).

The PR also lacks tests.

@graemerocher graemerocher marked this pull request as draft November 16, 2022 10:36
@graemerocher graemerocher removed this from the 4.5.0 milestone Nov 16, 2022
@yjiao-5028 yjiao-5028 closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants