Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to build plugins 6.1.1, update version catalog and dependencies to correspond to changed bom/platform architecture, misc build fixes. #641

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Dec 19, 2022

No description provided.

…es to correspond to changed bom/platform architecture, misc build fixes.
@timyates
Copy link
Contributor

I think this is failing because of Config changes in core 🤔

For Streams, it seems to call this for each config (if I add a name Parameter to this method, there is a name injected)

@EachBean(AbstractKafkaStreamsConfiguration.class)
ConfiguredStreamBuilder streamsBuilder(AbstractKafkaStreamsConfiguration<?, ?> configuration) {
return new ConfiguredStreamBuilder(configuration.getConfig());
}

But then when it tries to use these to generate the streams, there is no name parameter

@EachBean(ConfiguredStreamBuilder.class)
@Context
KafkaStreams kafkaStreams(
@Parameter String name,
ConfiguredStreamBuilder builder,
KafkaClientSupplier kafkaClientSupplier,
KStream<?, ?>... kStreams
) {

So it is failing...

@dstepanov any ideas?

@timyates
Copy link
Contributor

This requires this fix in core to support the kafka streams

micronaut-projects/micronaut-core#8510

We still have a single test that seems to be failing for me locally

It's specifically annotated to not run on CI though 🙄 so I'm not sure if it's failing because of a change in 4.0.0, or if it's failing because it hasn't worked for ages

@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

❌ GraalVM CE CI 17 latest failed: https://ge.micronaut.io/s/ne2c7frz2qmdy

@sdelamo sdelamo merged commit f825f5b into master Dec 21, 2022
@sdelamo sdelamo deleted the update_to_build_6.1.1 branch December 21, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants