Add support for batch Acknowledgement. (#54) #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@jeremyg484 you have to sign the CLA. |
sdelamo
requested changes
Apr 14, 2023
kafka/src/main/java/io/micronaut/configuration/kafka/processor/KafkaConsumerProcessor.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/processor/KafkaConsumerProcessor.java
Outdated
Show resolved
Hide resolved
sdelamo
reviewed
Apr 20, 2023
|
There are check style errors |
jeremyg484
force-pushed
the
BatchAcknowledge2
branch
from
9d97741
to
13e43b3
Compare
sdelamo
approved these changes
Apr 24, 2023
guillermocalvo
added a commit
that referenced
this pull request
Oct 2, 2023
Based-on: #692 Co-authored-by: Jeremy Grelle <grellej@unityfoundation.io>
sdelamo
pushed a commit
that referenced
this pull request
Nov 9, 2023
Based-on: #692 Co-authored-by: Jeremy Grelle <grellej@unityfoundation.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for an
Acknowledgementparameter in batchKafkaListenermethods. Addresses Issue #54Update docs for consistency between one-by-one processing and batch, including linking to the correct
Acknowledgementclass reference from the Micronaut messaging package.