Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict AdminClient permission for KafkaHealthIndicator #810

Merged

Conversation

guillermocalvo
Copy link
Contributor

Closes #423

@guillermocalvo guillermocalvo added the type: enhancement New feature or request label Aug 10, 2023
@guillermocalvo guillermocalvo linked an issue Aug 10, 2023 that may be closed by this pull request
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding a new configuration could we use the already existing Endpoint Sensitivity
and the settingendpoints.health.details.visible.

@guillermocalvo
Copy link
Contributor Author

instead of adding a new configuration could we use the already existing Endpoint Sensitivity and the settingendpoints.health.details.visible.

Yeah I can use details.visible instead. However, I think it could be a bit confusing to the user if a simple matter of displaying/hiding details (as "visible" suggests) ends up having other implications: the restricted version doesn't take into account the configured replication factor (it just checks that it can connect to some node in the cluster).

As for the sensitive flag, I don't think I understand how you'd like to use it to control which one of the two versions should be enabled. As far as I understand, endpoint sensitivity determines who can access the endpoint, not what the endpoint should be doing.

@sdelamo Could you please elaborate on what your preferred solution would be? Thank you!

@sdelamo sdelamo requested a review from dstepanov August 16, 2023 11:29
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

84.3% 84.3% Coverage
0.0% 0.0% Duplication

@sdelamo sdelamo merged commit 07b6c9b into master Aug 16, 2023
7 checks passed
@sdelamo sdelamo deleted the 423-restrict-adminclient-permission-for-kafkahealthindicator branch August 16, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Restrict AdminClient permission for KafkaHealthIndicator
3 participants