Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid log pollution while waiting for consumer to close #821

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Avoid log pollution while waiting for consumer to close #821

merged 2 commits into from
Aug 17, 2023

Conversation

guillermocalvo
Copy link
Contributor

While investigating #557, I came across this nagging TRACE message that keeps polluting my logs:

TRACE i.m.c.k.p.KafkaConsumerProcessor - consumer not closed yet
TRACE i.m.c.k.p.KafkaConsumerProcessor - consumer not closed yet
TRACE i.m.c.k.p.KafkaConsumerProcessor - consumer not closed yet
...

I've made some changes to limit how often we log this message while we're actively waiting for a consumer to close.

@guillermocalvo guillermocalvo added the type: improvement A minor improvement to an existing feature label Aug 17, 2023
@guillermocalvo guillermocalvo self-assigned this Aug 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sdelamo sdelamo merged commit b0d144b into master Aug 17, 2023
6 of 7 checks passed
@sdelamo sdelamo deleted the avoid-log-pollution-while-waiting-for-consumer-to-close branch August 17, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo approved these changes

@dstepanov dstepanov Awaiting requested review from dstepanov

Assignees

@guillermocalvo guillermocalvo

Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
4.1.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillermocalvo @sdelamo