Refactor KafkaConsumerProcessor
#871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillermocalvo
force-pushed
the
refactor-kafka-consumer-processor
branch
from
9c1fba7
to
6d2bf10
Compare
guillermocalvo
force-pushed
the
refactor-kafka-consumer-processor
branch
from
6d2bf10
to
815780e
Compare
guillermocalvo
force-pushed
the
refactor-kafka-consumer-processor
branch
from
1188b37
to
a03c37e
Compare
sdelamo
requested changes
Sep 22, 2023
kafka/src/main/java/io/micronaut/configuration/kafka/annotation/ErrorStrategyValue.java
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/annotation/ErrorStrategyValue.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/processor/ConsumerCloseState.java
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/processor/ConsumerSeekAwareAdapter.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/processor/ConsumerSeekAwareAdapter.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/processor/ConsumerState.java
Show resolved
Hide resolved
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(KafkaConsumerProcessor.class); // NOSONAR | ||
|
|
||
| final ConsumerInfo info; |
There was a problem hiding this comment.
It's package-protected on purpose. Please note that ConsumerState itself is an @Internal, package-protected class.
| final ConsumerInfo info; | ||
| final Consumer<?, ?> kafkaConsumer; | ||
| final Set<String> subscriptions; | ||
| Set<TopicPartition> assignments; |
There was a problem hiding this comment.
Package-protected on purpose.
dstepanov
reviewed
Sep 22, 2023
kafka/src/main/java/io/micronaut/configuration/kafka/processor/ConsumerState.java
Show resolved
Hide resolved
dstepanov
reviewed
Sep 22, 2023
kafka/src/main/java/io/micronaut/configuration/kafka/processor/ConsumerInfo.java
Show resolved
Hide resolved
This reverts commit a583708.
jeremyg484
suggested changes
Sep 26, 2023
Disclaimer: some of these classes already existed, but didn't have any authorship / version info available.
guillermocalvo
force-pushed
the
refactor-kafka-consumer-processor
branch
from
8b89349
to
447b8da
Compare
dstepanov
approved these changes
Sep 26, 2023
|
Kudos, SonarCloud Quality Gate passed! |
jeremyg484
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted some internal classes out of
KafkaConsumerProcessorand split some methods into smaller ones.