Support for ConsumerRecords container type on batch processing #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremyg484 can you please review this? |
jeremyg484
suggested changes
Nov 13, 2023
kafka/src/main/java/io/micronaut/configuration/kafka/processor/KafkaConsumerProcessor.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/io/micronaut/configuration/kafka/processor/KafkaConsumerProcessor.java
Outdated
Show resolved
Hide resolved
rorueda
force-pushed
the
consumer-records-support
branch
from
64de308
to
0e52c61
Compare
|
I rebased it onto master and made the requested change. |
jeremyg484
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #903
The changes are:
ConsumerRecordstype;ConsumerRecordstype when looking for the "body argument" to configure the correct key and value deserializers;