ci: version to 4.0.0 Micronaut 4.0.0-SNAPSHOT githubCoreBranch=4.0.x

[wetted]

No description provided.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[wetted]

This has some issues with three tests that worked on master but break now. But it doesn't break with this branch alone. If I change master from Micronaut 3.3.4 to 3.5.0, the same three tests break as well. I know at least one seems due to changes in the BeanContext refactoring that was done for Micronaut 3.5.0. Any ideas about this @dstepanov? Can you please have a look at RateLimitingQueueFactorySpec? I think that's a problem with changes to BeanContext or rather DefaultBeanContext in core. I don't know about the others yet (ConfigMapResourceReconcilerSpec and ConfigMapResourceReconcilerWithFiltersSpec).

[timyates]

The Unsupported class file major version 61 error seems to be caused by cglib when Spock tries to create a Stub (in some situations)

I could work around it by adding

configurations {
    testRuntimeClasspath {
        resolutionStrategy.dependencySubstitution {
            substitute module('cglib:cglib-nodep') using module('net.bytebuddy:byte-buddy:1.12.18')
        }
    }
}

To the builds in question (to replace cglib with byte-buddy at test runtime)

We add cglib in our internal tools

https://github.com/micronaut-projects/micronaut-build/blob/d3b3d0e7c4187af0c2c3d09986decc02322feccd/src/main/groovy/io/micronaut/build/MicronautBuildCommonPlugin.groovy#L85-L87

Should we be thinking about migrating to byte-buddy for 4.0.0? I don't know about the state of either library enough to make a call...

@melix @sdelamo @graemerocher

[graemerocher]

Yes move to bytebuddy

Cglib is not maintained anymore

[timyates]

@wetted io.micronaut.build.shared.settings 6.0.1 is out which uses bytebuddy instead of cglib 🤞

[wetted]

@wetted io.micronaut.build.shared.settings 6.0.1 is out which uses bytebuddy instead of cglib 🤞

Thanks @timyates . I'll make the change and push it.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[timyates]

Hmmm... fails on CI and fails differently locally

Did you get this passing locally @wetted ?

Maybe @alvarosanchez has seen the errors before?

[alvarosanchez]

The build is failing because the workflow is still calling a dependencyUpdates task that no longer exists.

In general, all workflows need to be updated "manually" comparing them with the project template. Also there are other workflows that should be removed (eg dependency-update.yml)

[wetted]

I'll fix the ci thing with workflows.

It still has two test issues. One has to do with duplicate beans. The other is a failure with: io.micronaut.context.exceptions.BeanInstantiationException: Bean definition [io.micronaut.kubernetes.client.operator.ConfigMapResourceReconciler] could not be loaded: Error instantiating bean of type [io.micronaut.kubernetes.client.operator.ControllerConfiguration]: Failed to resolve the 'apiGroup' for class io.kubernetes.client.openapi.models.V1ConfigMap from discovery cache.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[n0tl3ss]

Blocked by micronaut-projects/micronaut-core#8593

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

100.0% Coverage
0.0% Duplication

[wetted]

Interesting about all the failures. When I run locally only ConfigMapResourceReconcilerSpec and ConfigMapResourceReconcilerWithFiltersSpec are failing.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[sdelamo]

I assume this is superseded by #548