Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for histograms #740

Merged
merged 3 commits into from
May 22, 2024
Merged

Adding support for histograms #740

merged 3 commits into from
May 22, 2024

Conversation

lcavadas
Copy link
Contributor

@lcavadas lcavadas commented Apr 17, 2024 •
edited
Loading

  • Added a new HttpHistogramMeterFilterFactory class to contribute to the configuration of the 'http.server.requests' and 'http.client.requests' meters.

  • Added test to validate configuration takes effect.

@lcavadas
Adding support for histograms
6126654 
- Added a new HttpHistogramMeterFilterFactory class to contribute to the configuration of the 'http.server.requests' and 'http.client.requests' meters.

- Renamed the existing HttpMeterFilterFactory to HttpPercentilesMeterFilterFactory in order for the naming of both classes to be consistent.

- Added test to validate configuration takes effect.
@CLAassistant
Copy link

CLAassistant commented Apr 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lcavadas lcavadas mentioned this pull request Apr 17, 2024
Closed
@sdelamo sdelamo requested a review from jeremyg484 April 19, 2024 05:45
@lcavadas
CR Fix
4b166d7 
Leave the original percentiles class alone so this PR can be released as a patch
@lcavadas
CR Fix
a9d88dd 
Leave the original percentiles class alone so this PR can be released as a patch
@lcavadas lcavadas requested a review from sdelamo April 19, 2024 07:38
@graemerocher graemerocher added the type: enhancement New feature or request label May 22, 2024
@graemerocher graemerocher changed the base branch from 5.5.x to 5.6.x May 22, 2024 09:46
@graemerocher graemerocher merged commit 9bc9f23 into micronaut-projects:5.6.x May 22, 2024
1 check passed
@graemerocher
Copy link
Contributor

Thanks for the contribution!

@lcavadas lcavadas deleted the issue-739 branch May 22, 2024 19:22
@lcavadas lcavadas mentioned this pull request May 23, 2024
Merged
scprek
scprek reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@scprek scprek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm docs are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scprek scprek scprek left review comments

@graemerocher graemerocher graemerocher approved these changes

@jeremyg484 jeremyg484 Awaiting requested review from jeremyg484

@sdelamo sdelamo Awaiting requested review from sdelamo

Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
No open projects
4.5.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcavadas @CLAassistant @graemerocher @sdelamo @scprek