Issue #70 - Detect kotlin coroutine calls. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croudet
force-pushed
the
Issue#70
branch
4 times, most recently
from
57ef10a
to
506d03c
Compare
graemerocher
requested changes
Jun 13, 2020
| } else { | ||
| // last argument | ||
| final String[] argumentNames = context.getArgumentNames(); | ||
| final MutableArgumentValue<?> argument = context.getParameters().get(argumentNames[argumentNames.length - 1]); |
There was a problem hiding this comment.
context.getParameters() is relatively expensive, and you don't need the MutableArgument value for these case. Use getParameterValues()[argumentNames.length - 1] instead which will provide better performance
| return result; | ||
| } | ||
|
|
||
| private static boolean isKotlinContinuation(MethodInvocationContext<Object, Object> context) { |
There was a problem hiding this comment.
I believe for this you can just call context.getExecutableMethod().isSuspend()
|
Couple of changes, thanks for the contribution! |
|
Are we sure that the last argument will always be of type |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.