Add StreamingFileUploadRequest #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in BlobParallelUploadOptions
|
|
|
Thanks @johanra Can you sign the CLA? |
|
@sdelamo CLA is signed now |
sdelamo
requested changes
Mar 28, 2024
| * @return An {@link UploadRequest} from the given {@link StreamingFileUpload}. | ||
| */ | ||
| @NonNull | ||
| static UploadRequest fromStreamingFileUpload(@NonNull StreamingFileUpload streamingFileUpload) { |
| * @param key the key under which the file will be stored (<code>path/to/file</code>) | ||
| * @return An {@link UploadRequest} from the given {@link StreamingFileUpload} and key. | ||
| */ | ||
| @NonNull |
| * | ||
| * An {@link UploadRequest} backed by a {@link StreamingFileUpload}. | ||
| */ | ||
| public class StreamingFileUploadRequest implements UploadRequest { |
yawkat
approved these changes
Apr 2, 2024
|
Hi Guys, |
I have the same question, specifically so we can use with AWS |
|
What is the current status of this topic? Has it stalled? |
|
Hi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes contains an implementation of StreamingFileUploadRequest and at the same time fixes #423 where the Azure implementation is calling getInputStream of the StreamingFileUploadRequest twice