-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StreamingFileUploadRequest #424
base: 2.5.x
Are you sure you want to change the base?
Conversation
in BlobParallelUploadOptions
Thanks @johanra Can you sign the CLA? |
@sdelamo CLA is signed now |
* @return An {@link UploadRequest} from the given {@link StreamingFileUpload}. | ||
*/ | ||
@NonNull | ||
static UploadRequest fromStreamingFileUpload(@NonNull StreamingFileUpload streamingFileUpload) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add @since
to javadoc
* @param key the key under which the file will be stored (<code>path/to/file</code>) | ||
* @return An {@link UploadRequest} from the given {@link StreamingFileUpload} and key. | ||
*/ | ||
@NonNull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add @since
to javadoc
* | ||
* An {@link UploadRequest} backed by a {@link StreamingFileUpload}. | ||
*/ | ||
public class StreamingFileUploadRequest implements UploadRequest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add @since
to javadoc
Hi Guys, |
I have the same question, specifically so we can use with AWS |
What is the current status of this topic? Has it stalled? |
Hi! |
This PR contributes contains an implementation of StreamingFileUploadRequest and at the same time fixes #423 where the Azure implementation is calling getInputStream of the StreamingFileUploadRequest twice