Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release a new version compatible with Micronaut 3.0 #74

Closed
ilopmar opened this issue Jun 17, 2021 · 5 comments
Closed

Release a new version compatible with Micronaut 3.0 #74

ilopmar opened this issue Jun 17, 2021 · 5 comments

Comments

@ilopmar
Copy link
Contributor

ilopmar commented Jun 17, 2021

Please follow the instructions in micronaut-projects/micronaut-core#5607 and update that core issue with the information related to the upgrade.
@harissecic
Copy link
Collaborator

Please follow the instructions in micronaut-projects/micronaut-core#5607 and update that core issue with the information related to the upgrade.

Given that this was never released should I still make those branches for switching or just keep this one's main up to date?

@graemerocher
Copy link
Contributor

Keeping the main one up to date is fine

@harissecic
Copy link
Collaborator

io.micronaut.context.scope.CustomScope has method that required javax.inject.Provider. PulsarProducerClientScope implements this interface and cannot be switched to the BeanProvider as suggested in the micronaut-projects/micronaut-core#5607.

@graemerocher
Copy link
Contributor

@harissecic a CustomScope is not needed here in reality. See micronaut-projects/micronaut-kafka#385 for how it will be removed in Kafka

harissecic pushed a commit that referenced this issue Jun 25, 2021
partial refactor for #74, kotlin inproper async call fix in tests
eeb772b
harissecic pushed a commit that referenced this issue Aug 18, 2021
Kotlin support (#70)
6284013 
* base app test for kotlin

* kotlin suspend listener fix

* spotless, checkstyle

* switch kotlin target to jdk1.8

* upgrade to 2.8 pulsar client, kotlin example changes

* checkstyle fix

* schema resolver protobuf, micronaut-test version bump

* partial refactor for #74, kotlin inproper async call fix in tests

* forgotten convert on publisher

* remove hardcoded port on kotlin test

* update dependecies

* refactor kotlin and java examples, bump dependencies

* bump testcontainers kotlin

* coroutines-pulsar future proxy, kotlin tests fix

* prolong await of tls message when running multiple tests

* forgotten scope on test bean, default queue should be 1000
@harissecic harissecic mentioned this issue Aug 22, 2021
Merged
@harissecic
Copy link
Collaborator

This runs properly with 3.0.0 micronaut. Only annotation left would be Pattern under javax. Is it safe to close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@graemerocher @ilopmar @harissecic