Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the feature oci-devops-build-ci to oracle-cloud-devops-build-ci #2391

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Rename the feature oci-devops-build-ci to oracle-cloud-devops-build-ci #2391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ore/src/main/java/io/micronaut/starter/feature/ci/workflows/oci/OCICiWorkflowFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
@Singleton
public class OCICiWorkflowFeature extends CIWorkflowFeature {

public static final String NAME = "oci-devops-build-ci";
public static final String NAME = "oracle-cloud-devops-build-ci";
private static final String WORKFLOW_FILENAME = "build_spec.yml";

@NonNull
Expand Down Expand Up @@ -79,6 +79,11 @@ private Template workflowRockerTemplate(GeneratorContext generatorContext) {
}
}

@Override
public boolean isPreview() {
return false;
}

@Override
public String getThirdPartyDocumentation() {
return "https://docs.oracle.com/en-us/iaas/Content/devops/using/build_specs.htm";
Expand Down
12 changes: 10 additions & 2 deletions ...re/src/test/groovy/io/micronaut/starter/feature/ci/workflows/oci/OCIWorkflowCISpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,16 @@ import spock.lang.Unroll

class OCIWorkflowCISpec extends BeanContextSpec implements CommandOutputFixture {

void "test oracle-cloud-devops-build-ci is a not a preview feature"() {
given:
OCICiWorkflowFeature feature = beanContext.getBean(OCICiWorkflowFeature)

expect:
!feature.isPreview()
}

@Unroll
void 'test oci-devops-build-ci is created for #buildTool and #jdkVersion'(BuildTool buildTool, JdkVersion jdkVersion) {
void 'test oracle-cloud-devops-build-ci is created for #buildTool and #jdkVersion'(BuildTool buildTool, JdkVersion jdkVersion) {
when:
def output = generate(ApplicationType.DEFAULT,
new Options(Language.JAVA, TestFramework.JUNIT, buildTool, jdkVersion),
Expand Down Expand Up @@ -54,7 +62,7 @@ class OCIWorkflowCISpec extends BeanContextSpec implements CommandOutputFixture
}

@Unroll
void 'test oci-devops-build-ci and graalvm is created for #buildTool and #jdkVersion'(BuildTool buildTool, JdkVersion jdkVersion) {
void 'test oracle-cloud-devops-build-ci and graalvm is created for #buildTool and #jdkVersion'(BuildTool buildTool, JdkVersion jdkVersion) {
when:
def output = generate(ApplicationType.DEFAULT,
new Options(Language.JAVA, TestFramework.JUNIT, buildTool, JdkVersion.valueOf(jdkVersion.majorVersion())),
Expand Down
Loading