Add OpenSearch features. #2421
Merged
Add OpenSearch features. #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #2414
sdelamo
requested changes
Mar 27, 2024
starter-core/src/main/java/io/micronaut/starter/feature/opensearch/OpenSearchFeature.java
Outdated
Show resolved
Hide resolved
starter-core/src/main/java/io/micronaut/starter/feature/opensearch/OpenSearchRestClient.java
Outdated
Show resolved
Hide resolved
...er-core/src/test/groovy/io/micronaut/starter/feature/opensearch/OpenSearchFeatureSpec.groovy
Outdated
Show resolved
Hide resolved
sdelamo
requested changes
Mar 27, 2024
There was a problem hiding this comment.
if the user selects Testcontainers. We should add https://github.com/micronaut-projects/micronaut-opensearch/blob/master/gradle/libs.versions.toml#L44 see #2413
I'll wait until #2413 is merged and make this a |
sdelamo
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2414