Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#571): TestResourcesPropertiesFactory supports user defined meta annotations #572

Conversation

ArnauAregall
Copy link
Contributor

See #571

  • If direct annotation on test class is not found, then look for meta annotations.
  • Fixes typo on instantiateProvider.

… user defined meta annotations

* If direct annotation on test class is not found, then look for meta annotations
* Fixes typo on instantiateProvider
Copy link
Collaborator

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the contribution!

@melix melix merged commit 097033e into micronaut-projects:master Mar 29, 2024
6 checks passed
@ArnauAregall
Copy link
Contributor Author

Thanks to you for the quick review! Could you please label it as type: improvement?

@melix melix added the type: improvement A minor improvement to an existing feature label Mar 29, 2024
@melix melix added this to the 2.4.1 milestone Mar 29, 2024
@ArnauAregall ArnauAregall deleted the feature/meta-test-resources-properties branch March 30, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants