Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotest 5.x.x support #508

Closed
glockbender opened this issue Dec 22, 2021 · 6 comments
Closed

Kotest 5.x.x support #508

glockbender opened this issue Dec 22, 2021 · 6 comments
Labels
help wanted Extra attention is needed type: enhancement New feature or request

Comments

@glockbender
Copy link

Issue description

Currently the plugin supports only 4.x.x kotest versions. Please provide support for kotest 5.x.x. See changelog for more info.

@glockbender
Copy link
Author

Here an error stacktrace when using kotest 5.0.3. With kotest 4.6.4 it's all ok

java.lang.NoSuchMethodError: 'io.kotest.core.test.Description$Test io.kotest.core.test.TestCase.getDescription()'
io.kotest.engine.extensions.ExtensionException$BeforeTestException: java.lang.NoSuchMethodError: 'io.kotest.core.test.Description$Test io.kotest.core.test.TestCase.getDescription()'
	at app//io.kotest.engine.test.TestExtensions$beforeTestBeforeAnyBeforeContainer$errors$4$2.invoke(TestExtensions.kt:89)
	at app//io.kotest.engine.test.TestExtensions$beforeTestBeforeAnyBeforeContainer$errors$4$2.invoke(TestExtensions.kt:89)
	at app//io.kotest.common.ResultsKt.mapError(results.kt:8)
	at app//io.kotest.engine.test.TestExtensions.beforeTestBeforeAnyBeforeContainer-gIAlu-s(TestExtensions.kt:89)
	at app//io.kotest.engine.test.TestExtensions$beforeTestBeforeAnyBeforeContainer$1.invokeSuspend(TestExtensions.kt)
	at app//kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at app//kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at java.base@15.0.5/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
	at java.base@15.0.5/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
	at java.base@15.0.5/java.lang.Thread.run(Thread.java:832)
Caused by: java.lang.NoSuchMethodError: 'io.kotest.core.test.Description$Test io.kotest.core.test.TestCase.getDescription()'
	at io.micronaut.test.extensions.kotest.MicronautKotestContext.beforeTest(MicronautKotestContext.kt:67)
	at io.micronaut.test.extensions.kotest.MicronautKotestExtension.beforeTest(MicronautKotestExtension.kt:58)
	at io.kotest.engine.test.TestExtensions.beforeTestBeforeAnyBeforeContainer-gIAlu-s(TestExtensions.kt:88)
	... 6 more

@melix
Copy link
Contributor

melix commented Jan 26, 2022

@graemerocher it looks like an issue for Micronaut Test, not the Gradle plugin?

@graemerocher graemerocher transferred this issue from micronaut-projects/micronaut-gradle-plugin Jan 27, 2022
@graemerocher graemerocher added type: enhancement New feature or request help wanted Extra attention is needed labels Mar 7, 2022
@Nandi
Copy link
Contributor

Nandi commented Mar 17, 2022

I would like to assist with this issue. What is the desired approach here:

  1. Update the kotest module in-place, causing breaking changes and no longer supporting Kotest verrsion before 5.x
  2. Create a new module for Kotest 5.x+

@graemerocher
Copy link
Contributor

graemerocher commented Mar 17, 2022

a new module for kotest 5.x

@Nandi
Copy link
Contributor

Nandi commented Mar 22, 2022

I have made a PR here #531

@graemerocher
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants