Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update junit5 monorepo to v5.9.0 #618

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 30, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.junit.jupiter:junit-jupiter-params (source) 5.8.2 -> 5.9.0 age adoption passing confidence
org.junit.jupiter:junit-jupiter-engine (source) 5.8.2 -> 5.9.0 age adoption passing confidence
org.junit.jupiter:junit-jupiter-api (source) 5.8.2 -> 5.9.0 age adoption passing confidence
org.junit:junit-bom (source) 5.8.2 -> 5.9.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Europe/Prague, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@renovate renovate bot changed the title chore(deps): update junit5 monorepo to v5.9.0 fix(deps): update junit5 monorepo to v5.9.0 Aug 1, 2022
@sdelamo
Copy link
Contributor

sdelamo commented Sep 13, 2022

@timyates can you investigate this?

@timyates
Copy link
Contributor

timyates commented Sep 13, 2022

One issue here is this is using a hardcoded Graal 22.0.0.1

I thought we switched that to 22.2 in the template project

Unfortunately, using 22.2 throws up a different error

@timyates
Copy link
Contributor

Clicked rebase so we have the single error to chase

@renovate renovate bot force-pushed the renovate/junit5-monorepo branch from 5c62220 to dec9389 Compare September 13, 2022 13:24
@timyates
Copy link
Contributor

It's still using the old Action with the hard coded Graal version...

@timyates
Copy link
Contributor

Created #634 which hopefully will supersede this once it runs the correct actions...

@timyates
Copy link
Contributor

timyates commented Sep 13, 2022

I was wrong... GrallVM CE Native CI action is different, and still uses 22.0.0.2

Switched to our plugin to perform the Graal config/reordering that needs to happen

Add the new JUnit class to initialize-at-build-time
@timyates timyates mentioned this pull request Sep 14, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo sdelamo merged commit ec2d678 into master Sep 14, 2022
@sdelamo sdelamo deleted the renovate/junit5-monorepo branch September 14, 2022 13:13
sdelamo added a commit that referenced this pull request Oct 10, 2022
* fix(deps): update junit5 monorepo to v5.9.0

* Fix Graal nativeCompile for JUnit module

Switched to our plugin to perform the Graal config/reordering that needs to happen

Add the new JUnit class to initialize-at-build-time

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Tim Yates <tim.yates@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants