Code cleanup #240
Merged
Code cleanup #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move tests from javax to jakarta. Remove unused imports.
sdelamo
reviewed
Oct 30, 2023
| * <p> | ||
| * A host string must be a domain string, an IPv4 address string, or "[", followed by an IPv6 address string, | ||
| * followed by "]". | ||
| */ | ||
| private static final Pattern DOMAIN_PATTERN = Pattern.compile( | ||
| DOMAIN + "|\\[" + IP_V6_DOMAIN + "\\]", CASE_INSENSITIVE | ||
| DOMAIN + "|\\[" + IP_V6_DOMAIN + "]", CASE_INSENSITIVE |
There was a problem hiding this comment.
Just redundant escape ] symbol:
sdelamo
reviewed
Oct 30, 2023
| ); | ||
|
|
||
| /** | ||
| * Regular expression for the domain part of an email address (everything after '@'). | ||
| */ | ||
| private static final Pattern EMAIL_DOMAIN_PATTERN = Pattern.compile( | ||
| DOMAIN + "|\\[" + IP_DOMAIN + "\\]|" + "\\[IPv6:" + IP_V6_DOMAIN + "\\]", CASE_INSENSITIVE | ||
| DOMAIN + "|\\[" + IP_DOMAIN + "]|" + "\\[IPv6:" + IP_V6_DOMAIN + "]", CASE_INSENSITIVE |
There was a problem hiding this comment.
Just redundant escape ] symbol:
|
Looks fine thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove semicolons from groovy files.
Move tests from javax to jakarta.
Remove unused imports.