Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbo Frames don't decorate views #792

Closed
sdelamo opened this issue Apr 26, 2024 · 1 comment · Fixed by #796
Closed

Turbo Frames don't decorate views #792

sdelamo opened this issue Apr 26, 2024 · 1 comment · Fixed by #796
Assignees
Labels
type: bug Something isn't working

Comments

@sdelamo
Copy link
Contributor

sdelamo commented Apr 26, 2024

I had to replace TurboFrameRenderer with:

package org.projectcheckins.security.http;

import io.micronaut.context.annotation.Replaces;
import io.micronaut.core.annotation.NonNull;
import io.micronaut.core.annotation.Nullable;
import io.micronaut.core.io.Writable;
import io.micronaut.http.HttpRequest;
import io.micronaut.http.MediaType;
import io.micronaut.views.ModelAndView;
import io.micronaut.views.ViewsModelDecorator;
import io.micronaut.views.ViewsRendererLocator;
import io.micronaut.views.turbo.TurboFrame;
import io.micronaut.views.turbo.TurboFrameRenderer;
import jakarta.inject.Singleton;

import java.util.Optional;

@Replaces(TurboFrameRenderer.class)
@Singleton
class TurboFrameRendererReplacement implements TurboFrameRenderer {
    private final ViewsModelDecorator viewsModelDecorator;
    private final ViewsRendererLocator viewsRendererLocator;
    private final String mediaType;

    TurboFrameRendererReplacement(ViewsModelDecorator viewsModelDecorator,
                                            ViewsRendererLocator viewsRendererLocator) {
        this.viewsModelDecorator = viewsModelDecorator;
        this.viewsRendererLocator = viewsRendererLocator;
        this.mediaType = MediaType.TEXT_HTML;
    }

    @SuppressWarnings("unchecked")
    @Override
    public @NonNull Optional<Writable> render(TurboFrame.Builder builder, @Nullable HttpRequest<?> request) {
        return builder.getTemplateView()
                .map(viewName -> {
                    Object model = builder.getTemplateModel().orElse(null);
                    ModelAndView<Object> modelAndView = new ModelAndView<>(viewName, model);
                    if (request != null && viewsModelDecorator != null) {
                        viewsModelDecorator.decorate(request, modelAndView);
                    }
                    Object decoratedModel = modelAndView.getModel().orElse(null);
                    return viewsRendererLocator.resolveViewsRenderer(viewName, mediaType, decoratedModel)
                            .flatMap(renderer -> builder.template(renderer.render(viewName, decoratedModel, request))
                                    .build()
                                    .render());
                })
                .orElseGet(() -> builder.build().render());
    }

}

We had the same bug with turbo streams: #778

@sdelamo sdelamo added the type: bug Something isn't working label Apr 26, 2024
timyates added a commit that referenced this issue Apr 29, 2024
As with TurboStream done here #778

Fixes #792
@timyates timyates linked a pull request Apr 29, 2024 that will close this issue
sdelamo pushed a commit that referenced this issue Apr 30, 2024
@sdelamo
Copy link
Contributor Author

sdelamo commented May 3, 2024

closed via fa533ae

@sdelamo sdelamo closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants