Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JTE fieldset TCK #900

Merged
merged 7 commits into from
Oct 15, 2024
Merged

JTE fieldset TCK #900

merged 7 commits into from
Oct 15, 2024

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Oct 11, 2024

This pull requests:

  • Creates the JTE views to pass the Form rendering TCK.
  • It also annotates HtmlJteViewsRenderer with @Primary. This allows the injection of ViewsRenderer<Map<String, Object>, ?> for JTE.
  • Adds the gg.jte:jte-native-resources as a managed dependency necessary for GraalVM compatibility.
  • For the test-suite-jte-tck module I set java 21 only because of:
> Task :test-suite-jte-fieldset:compileJava FAILED
/Users/sdelamo/github/micronaut-projects/micronaut-views/test-suite-jte-fieldset/build/generated-sources/jte/gg/jte/generated/precompiled/fieldset/JteinputurlGenerated.java:9: error: expression type InputUrlFormElement is a subtype of pattern type InputStringFormElement
                if (el instanceof InputStringFormElement inputStringFormElement) {
                       ^

@sdelamo sdelamo added the type: enhancement New feature or request label Oct 12, 2024
Copy link

sonarcloud bot commented Oct 12, 2024

@sdelamo sdelamo marked this pull request as ready for review October 13, 2024 10:02
@sdelamo sdelamo merged commit a4d3a90 into 5.5.x Oct 15, 2024
25 checks passed
@sdelamo sdelamo deleted the jte-fieldset branch October 15, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants