Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stever projection thresholds #592

Merged
merged 10 commits into from
Oct 13, 2021
Merged

Stever projection thresholds #592

merged 10 commits into from
Oct 13, 2021

Conversation

Fuhji
Copy link
Collaborator

@Fuhji Fuhji commented Sep 10, 2021 •
edited
Loading

  • fix projection thresholds not updating
  • fix projection availability chart failing to update after changing the side bar selection
  • applied annotation threshold fix to all other charts with threshold line (see random issue with workaround Annotation event not updating with Chart.js 2.7 chartjs/chartjs-plugin-annotation#88 (comment))
  • Reminder - As this is a PWA, when loading any deployment preview you need to clear the application (Chrome dev tools > Application > Storage > Clear site data) otherwise you are looking at the previous, cached version.

@github-actions
Copy link
Contributor

Pull Request Review Checklist:

  • Comments are present where appropriate, and provide useful information not just stating what the code is obviously doing.
  • Variable have been given sensible, meaningful names.
  • No values have been hard-coded where they should be drawn from a config file.
  • Error handling is performed appropriately where things might fail.

💡 Suggest edits/additions to this checklist at: https://github.com/micronutrientsupport/code-review-checklist/blob/master/checklist.md

@github-actions
Copy link
Contributor

The compodoc for this PR is being automatically deployed to Netlify.

🔍 Deploy log:
📖 Compodoc:

@github-actions
Copy link
Contributor

Bundle difference

Asset group Old size New size Diff
all 23.31 MB 23.31 MB 0 B (0.00%)
documents 0 B 0 B 0 B (0.00%)
scripts 9.93 MB 9.93 MB 0 B (0.00%)
stylesheets 207.23 KB 207.23 KB 0 B (0.00%)
images 1.73 MB 1.73 MB 0 B (0.00%)
misc 0 B 0 B 0 B (0.00%)

@github-actions
Copy link
Contributor

This pull request is being automatically deployed to Netlify.

🔍 Deploy log: https://app.netlify.com/sites/micronutrientsupport-tool/deploys/613b5d94163b3fd899804149
✅ Preview: https://preview592--micronutrientsupport-tool.netlify.app

@Fuhji Fuhji self-assigned this Sep 10, 2021
@Fuhji Fuhji requested a review from jon571 September 10, 2021 13:37
@Fuhji Fuhji marked this pull request as draft September 10, 2021 13:39
@Fuhji
Copy link
Collaborator Author

Fuhji commented Sep 10, 2021

works locally, netlify preview doesnt :-|

@github-actions
Copy link
Contributor

The compodoc for this PR is being automatically deployed to Netlify.

🔍 Deploy log:
📖 Compodoc:

@github-actions
Copy link
Contributor

Bundle difference

Asset group Old size New size Diff
all 23.31 MB 23.31 MB 0 B (0.00%)
documents 0 B 0 B 0 B (0.00%)
scripts 9.93 MB 9.93 MB 0 B (0.00%)
stylesheets 207.23 KB 207.23 KB 0 B (0.00%)
images 1.73 MB 1.73 MB 0 B (0.00%)
misc 0 B 0 B 0 B (0.00%)

@github-actions
Copy link
Contributor

This pull request is being automatically deployed to Netlify.

🔍 Deploy log: https://app.netlify.com/sites/micronutrientsupport-tool/deploys/613b635f8ffb92dba46495fb
✅ Preview: https://preview592--micronutrientsupport-tool.netlify.app

@github-actions
Copy link
Contributor

The compodoc for this PR is being automatically deployed to Netlify.

🔍 Deploy log:
📖 Compodoc:

@github-actions
Copy link
Contributor

Bundle difference

Asset group Old size New size Diff
all 23.32 MB 23.32 MB 0 B (0.00%)
documents 0 B 0 B 0 B (0.00%)
scripts 9.93 MB 9.93 MB 0 B (0.00%)
stylesheets 207.23 KB 207.23 KB 0 B (0.00%)
images 1.73 MB 1.73 MB 0 B (0.00%)
misc 0 B 0 B 0 B (0.00%)

@github-actions
Copy link
Contributor

This pull request is being automatically deployed to Netlify.

🔍 Deploy log: https://app.netlify.com/sites/micronutrientsupport-tool/deploys/616555e3c58837c363bd6d7c
✅ Preview: https://preview592--micronutrientsupport-tool.netlify.app

@github-actions
Copy link
Contributor

The compodoc for this PR is being automatically deployed to Netlify.

🔍 Deploy log:
📖 Compodoc:

@github-actions
Copy link
Contributor

Bundle difference

Asset group Old size New size Diff
all 23.32 MB 23.32 MB 0 B (0.00%)
documents 0 B 0 B 0 B (0.00%)
scripts 9.93 MB 9.93 MB 0 B (0.00%)
stylesheets 207.23 KB 207.23 KB 0 B (0.00%)
images 1.73 MB 1.73 MB 0 B (0.00%)
misc 0 B 0 B 0 B (0.00%)

@github-actions
Copy link
Contributor

This pull request is being automatically deployed to Netlify.

🔍 Deploy log: https://app.netlify.com/sites/micronutrientsupport-tool/deploys/61655bef518f14d0dd05ea05
✅ Preview: https://preview592--micronutrientsupport-tool.netlify.app

@github-actions
Copy link
Contributor

The compodoc for this PR is being automatically deployed to Netlify.

🔍 Deploy log:
📖 Compodoc:

@github-actions
Copy link
Contributor

Bundle difference

Asset group Old size New size Diff
all 23.32 MB 23.32 MB 0 B (0.00%)
documents 0 B 0 B 0 B (0.00%)
scripts 9.93 MB 9.93 MB 0 B (0.00%)
stylesheets 207.23 KB 207.23 KB 0 B (0.00%)
images 1.73 MB 1.73 MB 0 B (0.00%)
misc 0 B 0 B 0 B (0.00%)

@github-actions
Copy link
Contributor

This pull request is being automatically deployed to Netlify.

🔍 Deploy log: https://app.netlify.com/sites/micronutrientsupport-tool/deploys/61655ebe8ee2de04d84f12a0
✅ Preview: https://preview592--micronutrientsupport-tool.netlify.app

@github-actions
Copy link
Contributor

Bundle difference

Asset group Old size New size Diff
all 23.32 MB 23.32 MB -633 B (-0.00%)
documents 0 B 0 B 0 B (0.00%)
scripts 9.93 MB 9.93 MB -296 B (-0.00%)
stylesheets 208.42 KB 208.42 KB 0 B (0.00%)
images 1.73 MB 1.73 MB 0 B (0.00%)
misc 0 B 0 B 0 B (0.00%)

@github-actions
Copy link
Contributor

The compodoc for this PR is being automatically deployed to Netlify.

🔍 Deploy log:
📖 Compodoc:

@github-actions
Copy link
Contributor

This pull request is being automatically deployed to Netlify.

🔍 Deploy log: https://app.netlify.com/sites/micronutrientsupport-tool/deploys/61668cc10c58c7b2895e9add
✅ Preview: https://preview592--micronutrientsupport-tool.netlify.app

@github-actions
Copy link
Contributor

The compodoc for this PR is being automatically deployed to Netlify.

🔍 Deploy log:
📖 Compodoc:

@github-actions
Copy link
Contributor

Bundle difference

Asset group Old size New size Diff
all 23.32 MB 23.32 MB -843 B (-0.00%)
documents 0 B 0 B 0 B (0.00%)
scripts 9.93 MB 9.93 MB -371 B (-0.00%)
stylesheets 208.42 KB 208.42 KB 0 B (0.00%)
images 1.73 MB 1.73 MB 0 B (0.00%)
misc 0 B 0 B 0 B (0.00%)

@github-actions
Copy link
Contributor

This pull request is being automatically deployed to Netlify.

🔍 Deploy log: https://app.netlify.com/sites/micronutrientsupport-tool/deploys/61668fbc7f948b9f23df8283
✅ Preview: https://preview592--micronutrientsupport-tool.netlify.app

@Fuhji Fuhji marked this pull request as ready for review October 13, 2021 07:51
@Fuhji
Copy link
Collaborator Author

Fuhji commented Oct 13, 2021

@jon571 what feels like years later, this PR is ready for review....

jon571
jon571 approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@jon571 jon571 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.
Couldn't get it to fail in develop though.
I am getting a js error, but also getting that in develop, so all good. Probs because of an API change maybe.

@Fuhji
Copy link
Collaborator Author

Fuhji commented Oct 13, 2021 •
edited
Loading

Seems to work. Couldn't get it to fail in develop though. I am getting a js error, but also getting that in develop, so all good. Probs because of an API change maybe.

in develop go to projections, then see the availability chart = works. Then change the mineral e.g. zinc --> calcium, chart errors out.

test my branch, should work now

Did you clear site data as suggested before testing?

What JS error?

@jon571
Copy link
Contributor

jon571 commented Oct 13, 2021

Seems to work. Couldn't get it to fail in develop though. I am getting a js error, but also getting that in develop, so all good. Probs because of an API change maybe.

in develop go to projections, then see the availability chart = works. Then change the mineral e.g. zinc --> calcium, chart errors out.

test my branch, should work now

Did you clear site data as suggested before testing?

What JS error?

Yeah, was doing the clear cache. Not getting the js errors on your branch now. Dunno why. All good. Merging...

@jon571 jon571 merged commit 3e56285 into develop Oct 13, 2021
@Fuhji Fuhji deleted the stever-projectionThresholds branch February 17, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jon571 jon571 jon571 approved these changes

Assignees

@Fuhji Fuhji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fuhji @jon571