[osgi] Solutions for https://github.com/eclipse/microprofile/issues/33 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
reviewed
Aug 30, 2018
pom.xml
Outdated
| @@ -35,7 +35,10 @@ | |||
|
|
|||
| <!-- Versions of API dependencies --> | |||
| <osgi-annotation.version>1.0.0</osgi-annotation.version> | |||
|
|
|||
| <cdi.api.version>1.1</cdi.api.version> | |||
| <inject.api.version>1</inject.api.version> | |||
There was a problem hiding this comment.
it looks like never used
|
@pavolloffay updated! |
This was referenced Aug 31, 2018
|
@rotty3000 could you please rebase? |
pavolloffay
reviewed
Sep 6, 2018
pom.xml
Outdated
| @@ -35,7 +35,9 @@ | |||
|
|
|||
| <!-- Versions of API dependencies --> | |||
| <osgi-annotation.version>1.0.0</osgi-annotation.version> | |||
|
|
|||
| <cdi.api.version>1.1</cdi.api.version> | |||
There was a problem hiding this comment.
why downgrading to 1.1?
|
No real need to downgrade, however 1.2 is not required so, one should
always depend on the lowest possible API version to support widest use.
Not explicitly required. I will remove it.
…On Thu, Sep 6, 2018 at 11:28 AM, Pavol Loffay ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pom.xml
<#84 (comment)>
:
> @@ -35,7 +35,9 @@
<!-- Versions of API dependencies -->
<osgi-annotation.version>1.0.0</osgi-annotation.version>
-
+ <cdi.api.version>1.1</cdi.api.version>
why downgrading to 1.1?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI9TCACSPr2CXc6PxdMHm5zfFUPMcjrks5uYT8TgaJpZM4WTxRc>
.
--
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
(@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
(@liferay)
Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org> (@OSGiAlliance)
|
Signed-off-by: Raymond Auge <raymond.auge@liferay.com>
|
won't do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse/microprofile#33
Similar PRs