Skip to content

Accessibility fix for inline-actions on inputs #6060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Accessibility fix for inline-actions on inputs #6060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6adb999
Fix for inline-actions
Jul 7, 2021
7eac509
Input label
Jul 8, 2021
64cff1a
fact - set
Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/community/reactnative/src/components/containers/factset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export class FactSet extends React.Component {
let valueConfig = this.hostConfig.factSet.value;
factSetJson.facts.map((element, index) => {
renderedElement.push(
<View style={[styles.textContainer]} key={`FACT-${element.title}-${index}`}>
<View style={[styles.textContainer]} key={`FACT-${element.title}-${index}`} accessible={true}>
<Label
text={element.title}
size={titleConfig.size}
Expand Down
2 changes: 1 addition & 1 deletion source/community/reactnative/src/components/inputs/input-label.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default class InputLabel extends React.Component {
}
if (inputLabel) {
return (
<View style={styles.container}>
<View style={styles.container} accessible={typeof label == Constants.TypeString ? true: undefined}>
<View>{inputLabel}</View>
{this.isRequired && this.getRedAsterisk()}
</View>
Expand Down
7 changes: 6 additions & 1 deletion source/community/reactnative/src/components/inputs/input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,12 @@ export class Input extends React.Component {
<TouchableOpacity
disabled={inlineAction.isEnabled == undefined ? false : !inlineAction.isEnabled} //isEnabled defaults to true
opacity={inlineAction.isEnabled == undefined ? 1.0 : inlineAction.isEnabled ? 1.0 : 0.5}
onPress={() => { this.onClickHandle(onExecuteAction, Constants.InlineAction) }}>
onPress={() => { this.onClickHandle(onExecuteAction, Constants.InlineAction) }}
accessible={true}
accessibilityLabel={inlineAction.title}
accessibilityState={{disabled: inlineAction.isEnabled == undefined ? false : !inlineAction.isEnabled}}
accessibilityRole={'button'}
>
{Utils.isNullOrEmpty(inlineAction.iconUrl) ?
<Text style={[styles.inlineActionText, opacityStyle]}>{inlineAction.title}</Text> :
<Image
Expand Down