Adding resources for dynamic type ahead UI #8273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
As this PR is focusing on rendering and translating a design into code it would be great to have images or videos that show how the element is looking like at this point |
almedina-ms
reviewed
Feb 6, 2023
...ce/android/adaptivecards/src/main/java/io/adaptivecards/renderer/ITypeAheadCustomParams.java
Outdated
Show resolved
Hide resolved
almedina-ms
reviewed
Feb 6, 2023
...ce/android/adaptivecards/src/main/java/io/adaptivecards/renderer/http/HttpRequestResult.java
Outdated
Show resolved
Hide resolved
almedina-ms
reviewed
Feb 6, 2023
...tivecards/src/main/java/io/adaptivecards/renderer/registration/CardRendererRegistration.java
Outdated
Show resolved
Hide resolved
almedina-ms
reviewed
Feb 6, 2023
source/android/adaptivecards/src/main/res/drawable/adaptive_card_ic_baseline_search_24.xml
Show resolved
Hide resolved
almedina-ms
reviewed
Feb 6, 2023
source/android/adaptivecards/src/main/res/drawable/adaptive_card_ic_baseline_search_24.xml
Show resolved
Hide resolved
almedina-ms
approved these changes
Feb 22, 2023
added 3 commits
February 23, 2023 11:52
…soft/AdaptiveCards into dipja/dynamic-type-ahead-2
…o dipja/dynamic-type-ahead-2
…soft/AdaptiveCards into dipja/dynamic-type-ahead-2
* adding new screen for dynamic type ahead * removing comments * updating sample app to use channel adaptor to fetch dynamic choices * fixing customization support in new type ahead screen * setting content description for buttons --------- Co-authored-by: dipja <dipja@Dipeshs-MacBook-Pro.local> Co-authored-by: dipja <dipja@Dipeshs-MBP.guest.corp.microsoft.com>
dipja
added a commit
that referenced
this pull request
Feb 24, 2023
* adding choices resolver for base element renderer * moving card level host interactions using channel adaptor * resolving comments * Adding resources for dynamic type ahead UI and new screen for type ahead (#8273) * adding resources for dynamic type ahead ui * adding custom icons * fix typo * addressing comments * adding msft copyright * Adding new screen for dynamic type ahead (#8274) * adding new screen for dynamic type ahead * removing comments * updating sample app to use channel adaptor to fetch dynamic choices * fixing customization support in new type ahead screen * setting content description for buttons --------- Co-authored-by: dipja <dipja@Dipeshs-MacBook-Pro.local> Co-authored-by: dipja <dipja@Dipeshs-MBP.guest.corp.microsoft.com> --------- Co-authored-by: dipja <dipja@Dipeshs-MacBook-Pro.local> Co-authored-by: dipja <dipja@Dipeshs-MBP.guest.corp.microsoft.com> * highting query text in dynamic choices * fixing error message visibility --------- Co-authored-by: dipja <dipja@Dipeshs-MacBook-Pro.local> Co-authored-by: dipja <dipja@Dipeshs-MBP.guest.corp.microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* adding choices resolver for base element renderer * moving card level host interactions using channel adaptor * resolving comments * Adding resources for dynamic type ahead UI and new screen for type ahead (microsoft#8273) * adding resources for dynamic type ahead ui * adding custom icons * fix typo * addressing comments * adding msft copyright * Adding new screen for dynamic type ahead (microsoft#8274) * adding new screen for dynamic type ahead * removing comments * updating sample app to use channel adaptor to fetch dynamic choices * fixing customization support in new type ahead screen * setting content description for buttons --------- Co-authored-by: dipja <dipja@Dipeshs-MacBook-Pro.local> Co-authored-by: dipja <dipja@Dipeshs-MBP.guest.corp.microsoft.com> --------- Co-authored-by: dipja <dipja@Dipeshs-MacBook-Pro.local> Co-authored-by: dipja <dipja@Dipeshs-MBP.guest.corp.microsoft.com> * highting query text in dynamic choices * fixing error message visibility --------- Co-authored-by: dipja <dipja@Dipeshs-MacBook-Pro.local> Co-authored-by: dipja <dipja@Dipeshs-MBP.guest.corp.microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature - [Android][Second PR] Dynamic Type Ahead
This is the second PR covers code changes to add drawables as UI resources in dynamic type ahead new screen. Also, provides support for custom icons from host.
Feature Details: https://github.com/microsoft/AdaptiveCards/blob/dipja/dynamic-type-ahead-doc-android/specs/DesignDiscussions/DynamicTypeAhead.md
Design Doc: https://github.com/microsoft/AdaptiveCards/blob/dipja/dynamic-type-ahead-doc-android/specs/DesignDiscussions/DynamicTypeAheadAndroid.md
Microsoft Reviewers: Open in CodeFlow
Type ahead state icons
Start Searching State Icon
Error/NoResult State Icon
Select/Tick Icon
Chevon Icon
Search Icon
Back Icon
Cross Button
