Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 4, 2025

Addresses feedback on inconsistent baggageScope.dispose() pattern in the OpenAI Agent sample. The Devin sample calls dispose() after run() completes (not in a finally block), while this sample was wrapping the entire operation in try-finally.

Changes

  • Removed try-finally wrapper around baggageScope.run() in nodejs/openai/sample-agent/src/agent.ts
  • Call dispose() after run() completes, matching the Devin sample pattern
// Before
try {
  await baggageScope.run(async () => { ... });
} finally {
  baggageScope.dispose();
}

// After
await baggageScope.run(async () => { ... });
baggageScope.dispose();

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

pontemonti and others added 30 commits November 5, 2025 10:19
* Added CODEOWNERS

* Added .gitignore

---------

Co-authored-by: Johan Broberg <johanb@microsoft.com>
Co-authored-by: Johan Broberg <johanb@microsoft.com>
Co-authored-by: Johan Broberg <johanb@microsoft.com>
Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
Co-authored-by: Johan Broberg <johanb@microsoft.com>
Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* Adding Python Agent Framework Sample

* update to latest

---------

Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
Co-authored-by: Rahul Devikar <radevika@microsoft.com>
* Revise README for Agent 365 Sample Agent

Updated the README to improve clarity and correct typos. Added sections on prerequisites, running the sample, and troubleshooting.

* Update README to remove external sample reference

Removed reference to the semantic-kernel-multiturn sample.
Co-authored-by: Rahul Devikar <radevika@microsoft.com>
* update agents sdk version for langchain

* Accept more recent versions

* remove authority field, this is set by default

---------

Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* Adding Notifications on AF

* Update readme

* PR comments

* small fix

* removed observability

* update manifest

* changes

* setup fix
Added comprehensive instructions for GitHub Copilot to follow during code reviews, including rules for checking keywords, copyright headers, and Agent 365 sample validation.
* update with api change

* update claude to tool service api name change

* name change

---------

Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* Add Vercel AI SDK sample

* fix comments

---------

Co-authored-by: Dominik Bezic <dominikbezic@microsoft.com>
* introducing perplexity sample agent

* applying changes from code review

* updated readme file with features list

---------

Co-authored-by: aubreyquinn <aubreyquinn+odspmdb@microsoft.com>
* Add OpenAI Nodejs Sample

* fix: model to string

* Add copyright headers

* Add build script

* fix typo

* fix typo in doc

* take comments

* update doc for env name change

* update license path in readme

* update walkthrough to follow same structure as AF

* include agentsplayground in readme

---------

Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
…ion (#31)

* Initial plan

* Rename "Microsoft Agents A365" to "Microsoft Agent 365"

Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>
Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* add updated nodejs claude implementation

* fix typos

* change mcp endpoint to prod

* review comments

* add auth from agents-hosting

* remove lock
* quickstart initial code

* rename folder

* update docs on quickstart

* add links and update docs

* include rename change

* copilot suggestions

---------

Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* Introducing playground notification handling in Perplexity agent

* Introducing playground Teams messaging notification handling in Perplexity agent

* applying changes from code review

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* applying changes from code review

* Add missing copyright header to playgroundActivityTypes.ts (#36)

* Initial plan

* Add Microsoft copyright header to playgroundActivityTypes.ts

Co-authored-by: aubreyquinn <80953505+aubreyquinn@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: aubreyquinn <80953505+aubreyquinn@users.noreply.github.com>

* Add copyright header to playgroundActivityTypes.ts (#35)

* Initial plan

* Add Microsoft copyright header to playgroundActivityTypes.ts

Co-authored-by: aubreyquinn <80953505+aubreyquinn@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: aubreyquinn <80953505+aubreyquinn@users.noreply.github.com>

---------

Co-authored-by: aubreyquinn <aubreyquinn+odspmdb@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
* Cursor IDE prompt usage



---------

Co-authored-by: shirahman <shirahman@microsoft.com>
* Update samples to remove environment id from calls and settings

* remove env id from newer samples

* Update python/agent-framework/sample-agent/.env.template

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fix formatting of 'Microsoft Agent365' to 'Microsoft Agent 365'

* Update README to reflect Microsoft Agent 365 SDK

* Fix typo in Agent365 authentication comment

* Fix comment formatting in client.ts

Updated comments to improve clarity and consistency.

* Fix typo in AGENT-TESTING.md

* Fix description formatting in pyproject.toml

* Update package description for clarity

* Fix formatting of Agent 365 configuration comment

* Update README to reference Microsoft Agent 365 SDK

* Fix typo in Agent 365 Observability SDK comment

* Update package description for clarity

* Fix description formatting in pyproject.toml

* Fix formatting in .env.template for Agent 365

* Update README.md

* Update README.md

* Fix naming in README for Agent Framework and SDK

Updated README to correct naming conventions for Agent Framework and Microsoft Agent 365 SDK.

* Update license link in README.md

* Update perplexityClient.ts

* Update README to reference Microsoft Agent 365 SDK

* Fix typo in LangChain client documentation

* Update README to reflect Microsoft Agent 365 SDK
aubreyquinn and others added 20 commits November 20, 2025 14:07
Co-authored-by: aubreyquinn <aubreyquinn+odspmdb@microsoft.com>
* Introducing the published agents-a365-* packages from npm into Perplexity

* applying changes from code review

---------

Co-authored-by: aubreyquinn <aubreyquinn+odspmdb@microsoft.com>
* move agent types to its own file

* add new section on "deploying the agent" to devin agent's readme

* add manifest sample to devin agent

* add copyright header
* work in progress

* adding telemetry markers to all paths in the code

* added telemetry essentials to env file

* Update nodejs/perplexity/sample-agent/src/perplexityAgent.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* applying changes from code review

* applying changes from code review

* applying changes from code review

* work in progress - tool call

* refactored perplexity agent into OOOP pattern

* updated code comment

* applying changes from code review

* applying changes from code review

---------

Co-authored-by: aubreyquinn <aubreyquinn+odspmdb@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: shirahman <shirahman@microsoft.com>
…lity (#81)

* Adding points for the users who contributed towards code review & quality

* adding leaderboard.json

* added permissions to the workflow

* resolved comments

---------

Co-authored-by: Lavanya Kappagantu <kalavany@microsoft.com>
* Add Agent Framework and Semantic Kernel enhancements

Introduced a new .NET Agent Framework Sample Agent with CI/CD setup, OpenTelemetry observability, and tools for weather and date-time retrieval. Added ASP.NET authentication utilities and Teams app manifest. Updated Semantic Kernel Sample Agent with streaming support, enhanced observability, and plugins for terms and conditions handling. Included configuration files, README, and `.gitignore` for better project structure and documentation.

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Refactor async handling in HTTP operations

Updated `InvokeObservedHttpOperation` to return `Task` for better async support and added `ConfigureAwait(false)` in `Program.cs` to prevent synchronization context capture. These changes improve performance, reliability, and adherence to async best practices.

* Refactor to support async in HTTP operation handling

Updated `Program.cs` to use `await` and `ConfigureAwait(false)` for `AgentMetrics.InvokeObservedHttpOperation` to ensure proper asynchronous execution.

Modified `AgentMetrics.cs` to change `InvokeObservedHttpOperation` from `void` to `Task` return type, aligning with async programming practices. Updated the method to handle asynchronous operations and return `Task.CompletedTask` for consistency.

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* adding authorization back to add tool servers call

* remove auth config for agentsplayground connection

* fixing claude sample

* fix indentation

* Add useJwtMiddleware if agent is hosted publicly

* change useJwt to isProd

* Namechange isProduction boolean

---------

Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* Creating a PR when the leaderboard needs to be updated

* addressed comments

---------

Co-authored-by: Lavanya Kappagantu <kalavany@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: fpfp100 <126631706+fpfp100@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on auto instrument configuration Align baggageScope.dispose() pattern with Devin sample Dec 4, 2025
Copilot AI requested a review from fpfp100 December 4, 2025 23:30
Base automatically changed from users/pefan/openaisamplefix to main December 8, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.