Merged
Conversation
Contributor
abdulanu0
commented
Jan 28, 2026
abdulanu0
commented
- Add nodejs-claude, python-claude, and nodejs-langchain jobs
- Add SDK version logging for all samples (Get-SDKVersions.ps1)
- Add prettified test conversation output (Emit-TestConversations.ps1)
- Add PR comment with test summary (skips manual/scheduled runs)
- Update summary job to include all 7 samples with status icons
- Add pull-requests: write permission for PR comments
✅ All E2E Tests Passed
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the E2E testing workflow for Agent 365 samples by adding support for Claude and LangChain integrations, improving observability through SDK version logging, and automating test result reporting via PR comments.
Changes:
- Added three new E2E test jobs: nodejs-claude, python-claude, and nodejs-langchain
- Created Get-SDKVersions.ps1 script to log installed SDK package versions across all runtimes
- Created Emit-TestConversations.ps1 script to format and display test conversation results
- Enhanced summary job with visual status icons and consolidated reporting
- Implemented automatic PR commenting with test results (only for pull_request events)
- Added pull-requests: write permission to enable PR commenting
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| scripts/e2e/Get-SDKVersions.ps1 | New PowerShell script to detect and log SDK versions for Python, Node.js, and .NET projects |
| scripts/e2e/Emit-TestConversations.ps1 | New PowerShell script to format test conversation JSON output into readable console and GitHub summary format |
| .github/workflows/e2e-agent-samples.yml | Added 3 new sample jobs, integrated SDK version logging and test conversation emission across all 7 jobs, enhanced summary with status icons, added PR comment automation, and updated permissions |
Collaborator
|
Can you also screenshot for the local testing for these samples? |
- Add nodejs-claude, python-claude, and nodejs-langchain jobs - Add SDK version logging for all samples (Get-SDKVersions.ps1) - Add prettified test conversation output (Emit-TestConversations.ps1) - Add PR comment with test summary (skips manual/scheduled runs) - Update summary job to include all 7 samples with status icons - Add pull-requests: write permission for PR comments
Use \ instead of \
Required for AgenticAuthorization handler
abdulanu0
force-pushed
the
users/anabdul/integration_test
branch
from
87f01f6 to
b5dc342
Compare
- Fix pipe character escaping in Emit-TestConversations.ps1 (use \\| instead of \|) - Fix Windows-specific path construction in Get-SDKVersions.ps1 (use nested Join-Path) - Fix package filtering to exclude A365 packages from Agents SDK list - Fix bash status icon syntax (use if-else instead of command substitution)
abdulanu0
changed the title
- Add flexible model configuration that checks for Azure OpenAI first - Fall back to regular OpenAI if Azure credentials not present - Update .env.example with both options documented - Provides clear error message if no credentials found
* fix: Correct YAML syntax in update-e2e-status workflow * fix: Apply Copilot review suggestions - proper URL encoding, empty string handling, textwrap.dedent, and job count tracking * Split into multiple workflows * refactor: Use workflow_call instead of workflow_dispatch for orchestrator - removes need for actions:write permission * fix: Correct PowerShell parameter names - use -AgentPID instead of -ProcessId, remove invalid -OutputPath and -TestName parameters * fix: Remove invalid test filter - test names BasicConversation and Notification don't exist * chore: Remove deprecated monolithic E2E workflow * chore: Remove deprecated monolithic E2E workflow
- Add LangChain E2E workflow (e2e-nodejs-langchain.yml) - Add SDK version logging step to all E2E workflows - Add test conversation emission step to all E2E workflows - Add PR test summary comment to orchestrator (only on PR events) - Update orchestrator to include LangChain and add pull-requests: write permission
rahuldevikar761
approved these changes
Jan 30, 2026
tmlsousa
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.