a365 setup blueprint and a365 cleanup fail with BadRequest: Location is required for external hosting configurations (needDeployment: false)

[sellakumaran]

Summary
Users who configure the CLI for external hosting ("needDeployment": false) do not set a location field in a365.config.json because it is not required for their setup. However, both a365 setup blueprint and a365 cleanup make calls to the Agent 365 endpoint registration API which requires Location in the request body. When location is absent from the config, these commands fail with a confusing server error.

Steps to Reproduce
Configure a365.config.json with "needDeployment": false and a messagingEndpoint (no location field):

{
"needDeployment": false,
"messagingEndpoint": "https://your-agent.example.com/api/messages",
...
}
Run a365 setup blueprint or a365 cleanup
Observed Behavior

ERROR: Failed to delete bot endpoint. Status: BadRequest
ERROR: Error response: {"errors":{"Location":["Location is required"]}}
WARNING: Failed to delete messaging endpoint
Expected Behavior
A clear, actionable error message telling the user to add a location field to their config, rather than a raw API validation error.

Root Cause
location is only validated as required when needDeployment: true (Azure hosting). For needDeployment: false, it is optional in the config schema. However, SetupHelpers.RegisterBlueprintMessagingEndpointAsync and BotConfigurator.DeleteEndpointWithAgentBlueprintAsync both pass location to the endpoint registration API unconditionally, with no guard for the empty case, causing a 400 BadRequest from the server.

Workaround
Add a location field to a365.config.json with the Azure region that was (or will be) used for endpoint registration:

"location": "eastus"
Affected Commands
a365 setup blueprint
a365 setup (full)
a365 cleanup
a365 cleanup blueprint
a365 cleanup blueprint --endpoint-only

[github-actions]

[AUTO-TRIAGE] Team Assistant Triage

This issue has been automatically analyzed and triaged.

AI Decision Reasoning: Type: Classified as 'bug' because the issue describes unexpected behavior where commands fail due to missing required fields in the API request.
Priority: Assigned P2 because the issue affects core functionality (setup and cleanup commands) and causes user confusion, but a workaround is available by adding a location field manually.
Copilot: The issue involves adding a guard condition to check for the presence of a 'location' field in the configuration before making API calls. This is a well-scoped, single-file change with clear requirements and a simple fix path.
Assignment: Issue is suitable for Copilot automated fix. The issue involves adding a guard condition to check for the presence of a 'location' field in the configuration before making API calls. This is a well-scoped, single-file change with clear requirements and a simple fix path.
Labels: Applied labels bug, P2 based on issue type and priority

Labels and assignee have been applied based on this analysis.

[github-actions]

[AUTO-TRIAGE] Results

Classification: bug
Priority: P2
Confidence: 100.0%

Recommended Assignee: @copilot

Analysis:
type rationale: Classified as 'bug' because the issue describes unexpected behavior where commands fail due to missing required fields in the API request.

priority rationale: Assigned P2 because the issue affects core functionality (setup and cleanup commands) and causes user confusion, but a workaround is available by adding a location field manually.

copilot rationale: The issue involves adding a guard condition to check for the presence of a 'location' field in the configuration before making API calls. This is a well-scoped, single-file change with clear requirements and a simple fix path.

assignment rationale: Issue is suitable for Copilot automated fix. The issue involves adding a guard condition to check for the presence of a 'location' field in the configuration before making API calls. This is a well-scoped, single-file change with clear requirements and a simple fix path.

labels rationale: Applied labels bug, P2 based on issue type and priority

[OK] This issue appears to be Copilot-fixable!

[SUGGESTION] Suggested Approach

1. Update the methods SetupHelpers.RegisterBlueprintMessagingEndpointAsync and BotConfigurator.DeleteEndpointWithAgentBlueprintAsync in src/Commands to check if location is null or empty before passing it to the endpoint registration API. If location is missing, log a clear error message instructing the user to add it to their a365.config.json file.
2. Modify the validation logic in the configuration schema for a365.config.json (likely in src/Configuration or a related helper class) to enforce that location is required even when needDeployment is set to false. This will prevent users from omitting location during setup.
3. Add unit tests in src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands to verify that the commands a365 setup blueprint and a365 cleanup blueprint handle missing location gracefully. Include tests for both valid and invalid configurations to ensure robust error handling.
4. Update the documentation in docs to explicitly mention that location is required in a365.config.json, regardless of the needDeployment value. Provide examples of valid configurations for both external hosting and Azure hosting setups.
5. Consider adding a pre-validation step in a365 setup blueprint and a365 cleanup blueprint commands (likely in src/Commands) to check the configuration file for required fields like location before making API calls. If fields are missing, display a user-friendly error message and halt execution.

---

Generated by TeamAssistant Auto-Triage powered by GitHub Models