Skip to content

Conversation

@threddy
Copy link
Contributor

@threddy threddy commented Feb 10, 2026

No description provided.

@threddy threddy requested a review from a team as a code owner February 10, 2026 23:30
Copilot AI review requested due to automatic review settings February 10, 2026 23:30
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Exposes CallerDetails (non-agentic caller identity metadata) on the ExecuteTool and Inference tracing scopes and ensures the same metadata flows into ETW/exporter payloads and DTO builders, with corresponding test coverage.

Changes:

  • Add optional callerDetails propagation into InferenceScope and ExecuteToolScope (via OpenTelemetryScope).
  • Extend ETW logging and DTO builders to include caller attributes (id/name/upn/client ip/tenant id).
  • Add/extend unit and integration tests validating caller tags/attributes across tracing, ETW, and exporter paths.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/Observability/Runtime/Tracing/Scopes/OpenTelemetryScope.cs Centralizes setting caller tags for all derived scopes via a new optional constructor parameter.
src/Observability/Runtime/Tracing/Scopes/InvokeAgentScope.cs Removes duplicated caller-tag logic and forwards callerDetails into the base scope.
src/Observability/Runtime/Tracing/Scopes/InferenceScope.cs Adds callerDetails to Start and forwards to OpenTelemetryScope for tag emission.
src/Observability/Runtime/Tracing/Scopes/ExecuteToolScope.cs Adds callerDetails to Start and forwards to OpenTelemetryScope for tag emission.
src/Observability/Runtime/Etw/IA365EtwLogger.cs Extends ETW logging interface methods to accept optional callerDetails.
src/Observability/Runtime/Etw/A365EtwLogger.cs Passes callerDetails into DTO builders for ETW serialization.
src/Observability/Runtime/DTOs/Builders/ExecuteToolDataBuilder.cs Adds caller attributes into execute_tool DTO attributes.
src/Observability/Runtime/DTOs/Builders/ExecuteInferenceDataBuilder.cs Adds caller attributes into inference DTO attributes.
src/Observability/Runtime/DTOs/Builders/BaseDataBuilder.cs Treats caller client IP as reserved and emits it from CallerDetails.
src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/Tracing/Scopes/InferenceScopeTest.cs New test asserting caller tags are set when provided.
src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/Tracing/Scopes/ExecuteToolScopeTest.cs New test asserting caller tags are set when provided.
src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/Etw/EtwLoggingBuilderTests.cs Extends ETW builder tests to validate caller attributes in emitted payload.
src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/DTOs/Builders/ExecuteToolDataBuilderTests.cs Extends DTO builder tests to validate caller attributes.
src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/DTOs/Builders/ExecuteInferenceDataBuilderTests.cs Extends DTO builder tests to validate caller attributes.
src/Tests/Microsoft.Agents.A365.Observability.Runtime.IntegrationTests/Agent365ExporterE2ETests.cs Extends exporter E2E assertions to validate caller attributes are exported.
Comments suppressed due to low confidence (1)

src/Observability/Runtime/Etw/IA365EtwLogger.cs:59

  • This file is missing the standard Microsoft copyright header at the top (other files in this folder include it, e.g., A365EtwLogger.cs). Since this file is being modified, please add the required header to align with repository conventions.
        public void LogInferenceCall(
            InferenceCallDetails inferenceCallDetails,
            AgentDetails agentDetails,
            TenantDetails tenantDetails,
            string conversationId,

@threddy threddy merged commit 1a54d91 into main Feb 11, 2026
7 checks passed
@threddy threddy deleted the users/threddy/add-caller-details branch February 11, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants