Conversation
rahuldevikar761
requested review from
juliomenendez,
nikhilNava and
pontemonti
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the version management approach across the Agent365 Python SDK by removing dynamic version calculation logic and replacing it with environment-based version configuration expected from CI/CD tooling (setuptools-git-versioning).
Key changes:
- Replaced custom
build_version()logic with simple environment variable reads usingAGENT365_PYTHON_SDK_PACKAGE_VERSION - Updated copyright headers from "Microsoft. All rights reserved." to "Copyright (c) Microsoft Corporation. Licensed under the MIT License."
- Deprecated the
build_version()function inversion_utils.pywith appropriate warnings
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| libraries/microsoft-agents-a365-tooling/setup.py | Simplified version management to use environment variable |
| libraries/microsoft-agents-a365-tooling-extensions-semantickernel/setup.py | Simplified version management to use environment variable |
| libraries/microsoft-agents-a365-tooling-extensions-openai/setup.py | Simplified version management to use environment variable |
| libraries/microsoft-agents-a365-tooling-extensions-azureaifoundry/setup.py | Simplified version management to use environment variable |
| libraries/microsoft-agents-a365-tooling-extensions-agentframework/setup.py | Simplified version management to use environment variable |
| libraries/microsoft-agents-a365-runtime/setup.py | Simplified version management to use environment variable |
| libraries/microsoft-agents-a365-runtime/microsoft_agents_a365/runtime/version_utils.py | Deprecated build_version() function with warning and updated documentation |
| libraries/microsoft-agents-a365-observability-extensions-semantickernel/setup.py | Simplified version management to use environment variable |
| libraries/microsoft-agents-a365-observability-extensions-openai/setup.py | Simplified version management to use environment variable |
| libraries/microsoft-agents-a365-observability-extensions-langchain/setup.py | Simplified version management to use environment variable |
| libraries/microsoft-agents-a365-observability-core/setup.py | Simplified version management to use environment variable |
| libraries/microsoft-agents-a365-notifications/setup.py | Simplified version management to use environment variable |
| .github/workflows/ci.yml | Updated CI workflow to use new environment variable name |
libraries/microsoft-agents-a365-runtime/microsoft_agents_a365/runtime/version_utils.py
Outdated
Show resolved
Hide resolved
pontemonti
reviewed
Nov 4, 2025
libraries/microsoft-agents-a365-runtime/microsoft_agents_a365/runtime/version_utils.py
Show resolved
Hide resolved
pontemonti
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.