Conversation
…mcp_server_configuration.py
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes lint errors in the test_mcp_server_configuration.py file by refactoring imports and updating type hints to follow modern Python conventions and PEP 8 standards.
Changes:
- Removed unused
Dictimport from typing module - Alphabetized imports within
unittest.mock(AsyncMock, MagicMock, patch) - Reordered imports to follow PEP 8: standard library, then third-party (pytest), then local modules
- Updated type hint from
Dict[str, Any]todict[str, Any](modern Python 3.9+ syntax)
rahuldevikar761
approved these changes
Jan 26, 2026
mrunalhirve128
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor imports and update type hint for mock_manifest_data in test_mcp_server_configuration.py