Refactor dependency management and add verification script by pontemonti · Pull Request #148 · microsoft/Agent365-python

pontemonti · 2026-01-28T07:29:55Z

Updated setup.py to enforce exact version matching for internal dependencies.
Enhanced pyproject.toml with new workspace extensions and centralized version constraints for external dependencies.
Introduced a new script (verify_constraints.py) to ensure proper configuration of version constraints across packages.
Modified uv.lock to reflect updated dependency specifications and removed version constraints from package metadata.

- Updated setup.py to enforce exact version matching for internal dependencies. - Enhanced pyproject.toml with new workspace extensions and centralized version constraints for external dependencies. - Introduced a new script (verify_constraints.py) to ensure proper configuration of version constraints across packages. - Modified uv.lock to reflect updated dependency specifications and removed version constraints from package metadata.

Copilot

Pull request overview

This pull request refactors dependency management by centralizing version constraints using uv's constraint-dependencies feature and introduces a verification script to enforce this pattern. The changes aim to improve maintainability by managing all external dependency versions in a single location.

Changes:

Added centralized constraint-dependencies in root pyproject.toml for all external dependencies
Removed version constraints from all 13 package pyproject.toml files
Updated all package setup.py files to use exact version matching for internal dependencies
Created scripts/verify_constraints.py to validate constraint configuration
Integrated verification script into CI workflow
Updated CLAUDE.md with dependency management documentation
Added comprehensive PRD and task breakdown documentation

Reviewed changes

Copilot reviewed 32 out of 33 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
pyproject.toml	Added constraint-dependencies with centralized version constraints for external packages; added all internal packages to [tool.uv.sources]
uv.lock	Regenerated lock file reflecting new constraint structure with version specifiers removed from package metadata
scripts/verify_constraints.py	New verification script to ensure version constraints are properly centralized and prevent regression
libraries/*/setup.py (13 files)	Updated to use exact version matching (use_exact_match=True) for internal dependencies
libraries/*/pyproject.toml (13 files)	Removed all version constraints from dependencies, keeping only package names
CLAUDE.md	Added documentation section explaining centralized dependency version management pattern
.github/workflows/ci.yml	Integrated verification script as CI check before linting
docs/prd/*.md	Added comprehensive PRD and task breakdown documentation for the feature

scripts/verify_constraints.py

CLAUDE.md

scripts/verify_constraints.py

pyproject.toml

rahuldevikar761 · 2026-01-28T07:43:13Z

Should we wait for this PR to go in first?
#147

Then we should create a package and deploy to get the fix first and then push the newer?

pontemonti · 2026-01-28T15:49:28Z

Should we wait for this PR to go in first? #147

Then we should create a package and deploy to get the fix first and then push the newer?

Yes, I think we should get your fix in first.

…verify_constraints.py

Copilot

Pull request overview

Copilot reviewed 32 out of 33 changed files in this pull request and generated 1 comment.

scripts/verify_constraints.py

Copilot

Pull request overview

Copilot reviewed 32 out of 33 changed files in this pull request and generated no new comments.

libraries/microsoft-agents-a365-notifications/setup.py

pyproject.toml

Copilot

Pull request overview

Copilot reviewed 32 out of 33 changed files in this pull request and generated 1 comment.

pyproject.toml

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 32 out of 33 changed files in this pull request and generated no new comments.

pontemonti requested review from a team as code owners January 28, 2026 07:29

pontemonti requested review from Copilot, rahuldevikar761 and tmlsousa January 28, 2026 07:29

Copilot started reviewing on behalf of pontemonti January 28, 2026 07:30 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

Johan Broberg added 2 commits January 28, 2026 07:54

refactor: Improve internal dependency handling in verify_constraints.py

2231b13

refactor: Update regex pattern formatting and improve readability in …

95d8e9a

…verify_constraints.py

Copilot AI review requested due to automatic review settings January 28, 2026 16:20

Copilot started reviewing on behalf of pontemonti January 28, 2026 16:20 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

scripts/verify_constraints.py Outdated Show resolved Hide resolved

Johan Broberg and others added 2 commits January 28, 2026 08:30

refactor: Update PACKAGE_NAME_PATTERN to enforce package name rules

2473356

Merge branch 'main' into users/johanb/CentralizedPackageVersions

b6d7bd0

Copilot AI review requested due to automatic review settings January 28, 2026 16:38

Copilot started reviewing on behalf of pontemonti January 28, 2026 16:39 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

rahuldevikar761 reviewed Jan 28, 2026

View reviewed changes

libraries/microsoft-agents-a365-notifications/setup.py Show resolved Hide resolved

rahuldevikar761 reviewed Jan 28, 2026

View reviewed changes

pyproject.toml Show resolved Hide resolved

rahuldevikar761 previously approved these changes Jan 28, 2026

View reviewed changes

mrunalhirve128 previously approved these changes Jan 28, 2026

View reviewed changes

Merge branch 'main' into users/johanb/CentralizedPackageVersions

887ab54

pontemonti dismissed stale reviews from mrunalhirve128 and rahuldevikar761 via 887ab54 February 2, 2026 16:48

pontemonti enabled auto-merge (squash) February 2, 2026 16:49

Add httpx dependency to pyproject.toml

c5504f9

Copilot AI review requested due to automatic review settings February 2, 2026 17:23

Copilot started reviewing on behalf of pontemonti February 2, 2026 17:23 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

Fix formatting in pyproject.toml dependencies

1085521

Copilot AI review requested due to automatic review settings February 2, 2026 17:42

Copilot started reviewing on behalf of pontemonti February 2, 2026 17:42 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

Merge branch 'main' into users/johanb/CentralizedPackageVersions

7402cf8

rahuldevikar761 approved these changes Feb 2, 2026

View reviewed changes

juliomenendez approved these changes Feb 2, 2026

View reviewed changes

nikhilNava approved these changes Feb 3, 2026

View reviewed changes

Merge branch 'main' into users/johanb/CentralizedPackageVersions

ac70f04

Copilot AI review requested due to automatic review settings February 3, 2026 18:21

Copilot started reviewing on behalf of pontemonti February 3, 2026 18:22 View session

pontemonti merged commit 5c27477 into main Feb 3, 2026
12 checks passed

pontemonti deleted the users/johanb/CentralizedPackageVersions branch February 3, 2026 18:23

Copilot AI reviewed Feb 3, 2026

View reviewed changes

Conversation

pontemonti commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rahuldevikar761 commented Jan 28, 2026

Uh oh!

pontemonti commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments