Skip to content

Comments

Add missing methods and attributes#15

Merged
nikhilNava merged 6 commits intomainfrom
nikhilc/addMissingFeatures
Nov 5, 2025
Merged

Add missing methods and attributes#15
nikhilNava merged 6 commits intomainfrom
nikhilc/addMissingFeatures

Conversation

@nikhilNava
Copy link
Contributor

Task
Introduce agent type and other helper attributes and methods on the SDK

Copilot AI review requested due to automatic review settings November 4, 2025 23:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the Microsoft Agents A365 observability library by adding new agent type support, caller details tracking, and extended telemetry methods. The changes improve the observability framework's ability to capture metadata about agents, their callers, and execution contexts.

  • Introduces AgentType enum and CallerDetails model for better agent classification and caller tracking
  • Adds new telemetry recording methods to scopes (record_input_messages, record_output_messages, record_response, etc.)
  • Updates copyright headers from "Microsoft. All rights reserved." to "Microsoft Corporation. Licensed under the MIT License."
  • Adds comprehensive unit tests for the new telemetry methods

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
models/agent_type.py Introduces AgentType enum with 5 agent classifications
models/caller_details.py Adds CallerDetails dataclass for tracking caller information
models/__init__.py Initializes models module with copyright header
agent_details.py Expands AgentDetails with new fields (auid, upn, blueprint_id, agent_type, tenant_id) and updates copyright
constants.py Adds new constants for agent type and thought process tracking
opentelemetry_scope.py Sets additional agent detail tags in telemetry spans
invoke_agent_scope.py Adds caller tracking, execution metadata, and message recording methods; updates copyright
inference_scope.py Adds methods for recording messages, tokens, response IDs, finish reasons, and thought processes; updates copyright
execute_tool_scope.py Adds record_response method and refactors variable extraction; updates copyright
trace_processor/util.py Includes GEN_AI_AGENT_TYPE_KEY in baggage attributes list
test_invoke_agent_scope.py Unit tests verifying existence of new recording methods on InvokeAgentScope
test_inference_scope.py Unit tests for new InferenceScope recording methods
test_execute_tool_scope.py Unit test for ExecuteToolScope record_response method
Comments suppressed due to low confidence (2)

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/constants.py:21

  • The constant name contains the keyword 'Kairo' which should be removed or replaced with appropriate terminology. Consider renaming to ENABLE_LEGACY_EXPORTER or removing if no longer needed, given that the codebase is transitioning away from 'Kairo' references.
ENABLE_KAIRO_EXPORTER = "ENABLE_KAIRO_EXPORTER"

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/constants.py:107

  • The constant name contains the keyword 'Kairo' which should be removed or replaced. While this is marked as 'Legacy constant for backward compatibility', consider deprecation strategy or renaming to LEGACY_AGENT_ID_KEY.
KAIRO_AGENT_ID_KEY = AGENT_ID_KEY

Copy link
Contributor

Copilot AI commented Nov 5, 2025

@nikhilNava I've opened a new pull request, #19, to work on those changes. Once the pull request is ready, I'll request review from you.

@nikhilNava nikhilNava requested a review from a team as a code owner November 5, 2025 12:44
Copilot AI review requested due to automatic review settings November 5, 2025 13:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 22 out of 36 changed files in this pull request and generated no new comments.

@nikhilNava nikhilNava merged commit b71b99f into main Nov 5, 2025
8 checks passed
@nikhilNava nikhilNava deleted the nikhilc/addMissingFeatures branch November 5, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants