Skip to content

Comments

Add use env id check to validation and update logs#21

Merged
joratz merged 1 commit intomainfrom
users/joratz/envcheck
Nov 5, 2025
Merged

Add use env id check to validation and update logs#21
joratz merged 1 commit intomainfrom
users/joratz/envcheck

Conversation

@joratz
Copy link
Contributor

@joratz joratz commented Nov 5, 2025

Validation checks on environment id should only run if the environment id is being used - when the env setting to use enviroment id is disabled, we should skip these checks.
Additionally, updated logs to only log environment info if environment id is being used.

Copilot AI review requested due to automatic review settings November 5, 2025 21:50
@joratz joratz requested a review from a team as a code owner November 5, 2025 21:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes environment_id conditionally required based on a feature flag get_use_environment_id(). The changes ensure that when the environment ID feature is disabled, validation and logging messages no longer require or reference the environment_id parameter.

Key changes:

  • Modified validation logic to skip environment_id checks when the feature is disabled
  • Updated logging messages to exclude environment_id when the feature is disabled

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mcp_tool_server_configuration_service.py Updated validation and logging to conditionally handle environment_id based on feature flag
mcp_tool_registration_service.py (semantickernel) Modified validation to conditionally require environment_id
mcp_tool_registration_service.py (openai) Updated logging to conditionally include environment_id
mcp_tool_registration_service.py (azureaifoundry) Updated logging and contains legacy "Kairo" imports that need updating
mcp_tool_registration_service.py (agentframework) Updated logging to conditionally include environment_id
Comments suppressed due to low confidence (1)

libraries/microsoft-agents-a365-tooling-extensions-azureaifoundry/microsoft_agents_a365/tooling/extensions/azureaifoundry/services/mcp_tool_registration_service.py:27

  • The imports reference 'microsoft_kairo' which is a legacy keyword that should be removed. These should be updated to use the correct package name 'microsoft_agents_a365.tooling' instead. Based on other files in the codebase, these imports should be: from ...common.services.mcp_tool_server_configuration_service import McpToolServerConfigurationService and from ...common.utils.constants import Constants.
from microsoft_kairo.tooling.common.services.mcp_tool_server_configuration_service import (
    McpToolServerConfigurationService,
)
from microsoft_kairo.tooling.common.utils.constants import Constants

@joratz joratz merged commit e2df634 into main Nov 5, 2025
14 checks passed
@pontemonti pontemonti deleted the users/joratz/envcheck branch December 5, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants