Skip to content

Comments

Remove environment ID parameter and usage in APIs#22

Merged
joratz merged 3 commits intomainfrom
users/joratz/removeenvid
Nov 12, 2025
Merged

Remove environment ID parameter and usage in APIs#22
joratz merged 3 commits intomainfrom
users/joratz/removeenvid

Conversation

@joratz
Copy link
Contributor

@joratz joratz commented Nov 6, 2025

Removing environment ID from all calls as it's no longer needed in calls to MCP platform.

This is a breaking change as we are changing public API signatures to remove the parameter.

Copilot AI review requested due to automatic review settings November 6, 2025 05:56
@joratz joratz requested a review from a team as a code owner November 6, 2025 05:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes the environment ID functionality from the MCP tooling codebase, simplifying the API surface and configuration management. The changes eliminate the conditional logic around environment IDs that was controlled by the USE_ENVIRONMENT_ID environment variable.

  • Removed environment_id parameter from all public APIs across multiple services
  • Removed the get_use_environment_id() utility function and related conditional logic
  • Simplified URL construction by removing environment-specific path variations
  • Updated documentation examples to reflect the simplified API

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
utility.py Removed get_use_environment_id() function and simplified URL construction logic in get_mcp_base_url() and build_mcp_server_url()
constants.py Removed ENVIRONMENT_ID constant from Headers class and updated docstring
mcp_tool_server_configuration_service.py Removed environment_id parameter from all methods and eliminated conditional logic based on get_use_environment_id()
mcp_tool_registration_service.py (semantickernel) Removed environment_id parameter and related header logic
mcp_tool_registration_service.py (openai) Removed environment_id parameter and conditional header setting
mcp_tool_registration_service.py (azureaifoundry) Removed environment_id parameter, fixed incorrect imports using microsoft_kairo package name
mcp_tool_registration_service.py (agentframework) Removed environment_id parameter and related header logic
README.md files Updated code examples to remove environment_id parameter
Comments suppressed due to low confidence (1)

libraries/microsoft-agents-a365-tooling-extensions-azureaifoundry/microsoft_agents_a365/tooling/extensions/azureaifoundry/services/mcp_tool_registration_service.py:27

  • The imports reference 'microsoft_kairo' package which appears to be incorrect. These should use 'microsoft_agents_a365.tooling' instead to match the actual package structure shown in other files.
from microsoft_kairo.tooling.common.services.mcp_tool_server_configuration_service import (
    McpToolServerConfigurationService,
)
from microsoft_kairo.tooling.common.utils.constants import Constants

@joratz joratz merged commit 028a357 into main Nov 12, 2025
8 checks passed
@pontemonti pontemonti deleted the users/joratz/removeenvid branch December 5, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants